pg.ddx.io  GitHub: pgjdbc/pgjdbc (issues + PRs as email threads)  
help / color / mirror / Atom feed
From: reda-alaoui (@reda-alaoui) <noreply+reda-alaoui@github.com>
To: pgjdbc/pgjdbc <noreply+pgjdbc-pgjdbc@github.com>
Subject: Re: [pgjdbc/pgjdbc] PR #3964: feat: add tcpKeepAliveCount, tcpKeepAliveIdle and tcpKeepAliveInterval connection properties
Date: Thu, 22 Oct 2026 10:24:18 +0000
Message-ID: <gh-pgjdbc-pgjdbc-3964-rc4347193915@github.com> (raw)
In-Reply-To: <gh-pgjdbc-pgjdbc-3964-rc4346009462@github.com>
References: <gh-pgjdbc-pgjdbc-3964@github.com>
	<gh-pgjdbc-pgjdbc-3964-rc4346009462@github.com>

(on pgjdbc/src/main/java/org/postgresql/ds/common/BaseDataSource.java)

Done in 76554b6c and 06cde2da. `tcpKeepAliveCount`, `tcpKeepAliveIdle` and `tcpKeepAliveInterval` now have `int` getters and setters. `-1` means unset: the getter returns it when the key is absent, and the setter removes the key when given it. `PGProperty.setInteger` is gone, since nothing uses it any more.

The `PGPropertyTest.dataSourceProperties` loop now asserts that every setter takes `String`, `int` or `boolean`. It fails on the previous `Integer` setters. It would also fail on `setAutosave(AutoSave)` and `setPreferQueryMode(PreferQueryMode)`, so the check skips those two: their setters take enums and are already released. Going by the `PropertyElf` conversions you listed, they should hit the same problem with HikariCP's `dataSourceClassName` configuration. Changing their types would have to go through deprecation, so I'd rather handle that in a separate issue than in this PR.

view thread (85+ messages)  latest in thread

Message-ID: <gh-pgjdbc-pgjdbc-3964-rc4347193915@github.com>
Permalink:  ../gh-pgjdbc-pgjdbc-3964-rc4347193915@github.com/

 · 


This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox