pgjdbc/pgjdbc GitHub issues and pull requests (mirror)
help / color / mirror / Atom feedFrom: davecramer (@davecramer) <[email protected]>
To: pgjdbc/pgjdbc <[email protected]>
Subject: Re: [pgjdbc/pgjdbc] PR #4016: feat: harden protocol reader against desynced streams (#4015)
Date: Sat, 23 May 2026 18:54:00 +0000
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
(on pgjdbc/src/main/java/org/postgresql/core/ProtocolViolationBehaviour.java)
The class Javadoc says "Default: {@link #WARN}" but the PR description says "Default: `fail`". The code confirms WARN is the default (`fromSystemProperty()` returns WARN on null/empty). The PR description's table has a discrepancy:
> | `fail` (default) | Poison `PGStream` and throw...
One of these is wrong. Looking at the code, WARN is clearly the default. The PR description's table should mark `warn` as the default, not `fail`.
view thread (21+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: github://pgjdbc/pgjdbc
Cc: [email protected], [email protected]
Subject: Re: [pgjdbc/pgjdbc] PR #4016: feat: harden protocol reader against desynced streams (#4015)
In-Reply-To: <<[email protected]>>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox