pgjdbc/pgjdbc GitHub issues and pull requests (mirror)  

help / color / mirror / Atom feed

From: sehrope (@sehrope) <[email protected]>
To: pgjdbc/pgjdbc <[email protected]>
Subject: Re: [pgjdbc/pgjdbc] PR #4063: fix: getCharacterStream wraps String in StringReader
Date: Mon, 11 May 2026 11:24:11 +0000
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>

Changing the class while still returning a `Reader` is not a breaking change. Anybody that is relying on the exact underlying implementation has been gambling that it will never change. And that user must have been explicitly casting the reader type too. So I doubt this is a problem in the real world and even if it is, it's the user's problem to fix.

This is a purely internal change and does not require maintaining any backwards compatible flag for the old behavior. If we want the change, just change the returned value and that's it.

view thread (14+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: github://pgjdbc/pgjdbc
  Cc: [email protected], [email protected]
  Subject: Re: [pgjdbc/pgjdbc] PR #4063: fix: getCharacterStream wraps String in StringReader
  In-Reply-To: <<[email protected]>>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox