pgjdbc/pgjdbc GitHub issues and pull requests (mirror)  

help / color / mirror / Atom feed

From: vlsi (@vlsi) <[email protected]>
To: pgjdbc/pgjdbc <[email protected]>
Subject: Re: [pgjdbc/pgjdbc] PR #4114: fix: PGXAConnection no longer saves and restores the caller's autoCommit
Date: Wed, 27 May 2026 09:51:17 +0000
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>

Thanks @denis-anisimov for testing.

@davecramer the PR is ready: 38 tests green, resolves [#3123](https://github.com/pgjdbc/pgjdbc/issues/3123) and [#3153](https://github.com/pgjdbc/pgjdbc/issues/3153) (both from 2024), aligns the no-touch-autoCommit behaviour with Oracle / MSSQL / MySQL drivers.

One open question for you: the PR currently ships refreshed translations for all 16 message catalogues (machine-generated; only Russian was reviewed by hand). Two options:

a) Keep them as shipped. The catalogues stay in sync with the new English messages; any fuzzy entries can be refreshed by native speakers later.
b) Drop everything but Russian. Non-Russian users see English fallback for the new messages until a native speaker refreshes them.

I lean towards (a) but I'm fine with (b). Which do you prefer?

view thread (13+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: github://pgjdbc/pgjdbc
  Cc: [email protected], [email protected]
  Subject: Re: [pgjdbc/pgjdbc] PR #4114: fix: PGXAConnection no longer saves and restores the caller's autoCommit
  In-Reply-To: <<[email protected]>>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox