pg.ddx.io  GitHub: pgjdbc/pgjdbc (issues + PRs as email threads)  
help / color / mirror / Atom feed
From: artemgavrilov (@artemgavrilov) <noreply+artemgavrilov@github.com>
To: pgjdbc/pgjdbc <noreply+pgjdbc-pgjdbc@github.com>
Subject: Re: [pgjdbc/pgjdbc] PR #4251: OAuth implementation
Date: Fri, 17 Jul 2026 13:22:01 +0000
Message-ID: <gh-pgjdbc-pgjdbc-4251-c5003717149@github.com> (raw)
In-Reply-To: <gh-pgjdbc-pgjdbc-4251@github.com>
References: <gh-pgjdbc-pgjdbc-4251@github.com>

Hi @vlsi , thanks for the review! I pushed new update that address majority of the comments, but some of them need your input:

> I'm not sure regarding pass-through only connection properties (oauthIssuer, oauthClientId, oauthClientSecret, oauthScope, oauthUsername). The driver does not use them, yet they become the public API.

I've added them after @davecramer [review comment ](https://github.com/pgjdbc/pgjdbc/pull/4251#issuecomment-4798663272) about context argument, which sounds reasonable. Do you have any ideas how it can be done in different way? User has to have some way to configure plugin, but its class instantiated late in connection factory. 

---

> CI execution produces a lot of warnings:

I can make this log to be printed only once per instance, instead of once per connection. Will it work? Removing this warning at all seems not the best option as user really shouldn't use this in production.

---





view thread (168+ messages)  latest in thread

Message-ID: <gh-pgjdbc-pgjdbc-4251-c5003717149@github.com>
Permalink:  ../gh-pgjdbc-pgjdbc-4251-c5003717149@github.com/

 · 


This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox