pg.ddx.io  GitHub: pgjdbc/pgjdbc (issues + PRs as email threads)  
help / color / mirror / Atom feed
From: davecramer (@davecramer) <noreply+davecramer@github.com>
To: pgjdbc/pgjdbc <noreply+pgjdbc-pgjdbc@github.com>
Subject: Re: [pgjdbc/pgjdbc] PR #4251: OAuth implementation
Date: Fri, 23 Oct 2026 04:48:09 +0000
Message-ID: <gh-pgjdbc-pgjdbc-4251-c6357624306@github.com> (raw)
In-Reply-To: <gh-pgjdbc-pgjdbc-4251@github.com>
References: <gh-pgjdbc-pgjdbc-4251@github.com>

 @artemgavrilov @ImTheKai sorry for the slow answer. I want to get this merged, and I agree that it needs a list that stops growing. Here is what I think has to change before
  merge. Everything else in vlsi's review can be a follow-up issue.

  Before merge:

  1. Rebase on master. It conflicts with the requireAuth change in AuthMethod.java.
  2. Fix readMechanisms so the list ends at the first empty name, as libpq does.
  3. Leave BaseDataSource.getUrl() as it is. Mask the URL where it is logged, but don't drop sslpassword from getUrl().
  4. Rename the setters and getters to setOauthToken, getOauthToken, and so on, and the classes to OauthTokenProvider and OauthTokenRequest, so HikariCP's dataSource.oauthToken
     works. This is public API, so it has to be right before the release.
  5. Settle OauthTokenRequest before it ships: no public constructor that fixes the fields, and add host, port, user and database so a provider can tell which server it is
     connecting to.
  6. Drop oauthIssuer, oauthClientId, oauthClientSecret and oauthScope for now. The driver doesn't use them, and the issuer check blocks connections that don't use OAuth. They
     can come back with the discovery PR.
  7. Put the server's error result in the exception instead of logging it at WARNING.
  8. Move the requireAuth and GSS fix to its own PR, so we can release it without OAuth.
  9. Add tests that the default oauthAllowInsecureConnection=false refuses an insecure connection, and that a successful OAuth login works with requireAuth=oauth.
  10. Fix the RFC citation: RFC 7628 ยง3 requires TLS but says nothing about verifying the certificate.

  Follow-ups, after merge: the logging volume, the doc restructure, the remaining test rewrites, a file-based token provider, the AuthenticationPlugin bridge, and the hint for
  managed services that take the token as a password.

  On the LLM question: we do use models to help review, and they keep finding new things. That is why I'm fixing the list here instead of asking for another round.


view thread (168+ messages)  latest in thread

Message-ID: <gh-pgjdbc-pgjdbc-4251-c6357624306@github.com>
Permalink:  ../gh-pgjdbc-pgjdbc-4251-c6357624306@github.com/

 · 


This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox