pg.ddx.io  GitHub: pgjdbc/pgjdbc (issues + PRs as email threads)  
help / color / mirror / Atom feed
From: vlsi (@vlsi) <noreply+vlsi@github.com>
To: pgjdbc/pgjdbc <noreply+pgjdbc-pgjdbc@github.com>
Subject: Re: [pgjdbc/pgjdbc] PR #4251: OAuth implementation
Date: Wed, 09 Sep 2026 15:45:36 +0000
Message-ID: <gh-pgjdbc-pgjdbc-4251-rc3970363249@github.com> (raw)
In-Reply-To: <gh-pgjdbc-pgjdbc-4251@github.com>
References: <gh-pgjdbc-pgjdbc-4251@github.com>

(on pgjdbc/src/main/java/org/postgresql/core/v3/ConnectionFactoryImpl.java)

`validateOAuthIssuer` runs only on the provider path, so a connection that sets `oauthToken` never reaches it. I confirmed that `oauthToken` together with `oauthIssuer=http://plain-http.example.com` connects with no error and no warning.

That may well be intended, since the issuer only matters to the provider. The problem is that `use.md` promises the opposite: the `oauthAllowInsecureIssuer` entry says a non-HTTPS issuer "is rejected with an error at connection time". Either move the call up so the check covers both paths, or say in the documentation that it applies only when a provider is called, and pin whichever you choose with a test.

view thread (168+ messages)  latest in thread

Message-ID: <gh-pgjdbc-pgjdbc-4251-rc3970363249@github.com>
Permalink:  ../gh-pgjdbc-pgjdbc-4251-rc3970363249@github.com/

 · 


This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox