From: vlsi (@vlsi) <noreply+vlsi@github.com>
To: pgjdbc/pgjdbc <noreply+pgjdbc-pgjdbc@github.com>
Subject: Re: [pgjdbc/pgjdbc] PR #4251: OAuth implementation
Date: Wed, 09 Sep 2026 15:45:36 +0000
Message-ID: <gh-pgjdbc-pgjdbc-4251-rc3970363271@github.com> (raw)
In-Reply-To: <gh-pgjdbc-pgjdbc-4251@github.com>
References: <gh-pgjdbc-pgjdbc-4251@github.com>
(on pgjdbc/src/main/java/org/postgresql/core/v3/OAuthAuthenticator.java)
Four points on these two messages.
The section number is wrong: RFC 7628 section 4 is "Examples". The TLS requirement is in section 3 and section 5.
The remedy is the wrong one. A user who hits this under `sslmode=disable` needs `sslmode=verify-full`, and `oauthAllowUnencryptedConnection=true` only silences the check while leaving the token exposed.
The warning does not name the reason it fired, so an operator who finds it in a log cannot tell which property to remove. It also fires on every connection, which for a pool means one line per connection in every refill.
Suggestion for both:
```java
GT.tr("OAUTHBEARER authentication requires a TLS- or GSS-encrypted connection, "
+ "as RFC 7628, section 3 requires. Enable TLS with sslmode=verify-full, or set "
+ "oauthAllowUnencryptedConnection=true for development and testing.")
```
```java
LOGGER.log(Level.WARNING,
"oauthAllowUnencryptedConnection=true: the bearer token is sent over a connection that is "
+ "neither TLS- nor GSS-encrypted. RFC 7628, section 3 requires TLS.");
```
The capitals and the exclamation mark do not add urgency that the level does not already carry, and this exact string is duplicated in `OAuthAuthenticatorTest` and `OAuthTest`, so rewording it today breaks two tests.