pg.ddx.io  GitHub: pgjdbc/pgjdbc (issues + PRs as email threads)  
help / color / mirror / Atom feed
From: vlsi (@vlsi) <noreply+vlsi@github.com>
To: pgjdbc/pgjdbc <noreply+pgjdbc-pgjdbc@github.com>
Subject: Re: [pgjdbc/pgjdbc] PR #4251: OAuth implementation
Date: Wed, 09 Sep 2026 15:45:36 +0000
Message-ID: <gh-pgjdbc-pgjdbc-4251-rc3970363328@github.com> (raw)
In-Reply-To: <gh-pgjdbc-pgjdbc-4251@github.com>
References: <gh-pgjdbc-pgjdbc-4251@github.com>

(on docs/content/documentation/use.md)

"By default, a non-HTTPS issuer is rejected with an error at connection time" does not hold for the configuration this page calls the preferred one. `validateOAuthIssuer` runs only inside the provider branch of `resolveOAuthToken`, so `oauthToken` together with `oauthIssuer=http://...` connects with no error. I checked against the live server.

Four facts are missing from the eight new entries, and each one is something a reader has to decide before configuring this:

- `sslmode`. The default is `prefer`, under which the server may refuse TLS and the connection continues in plaintext. OAUTHBEARER then fails, and the fix is `sslmode=require` or higher, not `oauthAllowUnencryptedConnection`.
- `channelBinding=require` is rejected outright with `Channel binding is not supported for OAuth authentication.`, and the `channelBinding` entry above says nothing about it. Slot it into both entries, since a reader arrives at only one of them.
- Precedence over SCRAM. When the server offers both mechanisms and either OAuth property is set, the driver picks OAUTHBEARER and never uses `password`. `requireAuth=scram-sha-256` is the way back.
- PostgreSQL 18. `matrix.mjs`, `entrypoint.sh` and the docker script header all know the `oauth` method needs 18; this page does not say so, and it has a precedent for the phrasing in `is only available for server version 17 or higher`.

Two smaller ones. None of the five error messages a user will search for is quoted here, and this page usually does quote them. `RFC 7628 §4` in the `oauthAllowUnencryptedConnection` entry should be a link to section 5 or section 3; the page already links RFC 3986 that way, and `§` appears nowhere else under `docs/content/`.

view thread (168+ messages)  latest in thread

Message-ID: <gh-pgjdbc-pgjdbc-4251-rc3970363328@github.com>
Permalink:  ../gh-pgjdbc-pgjdbc-4251-rc3970363328@github.com/

 · 


This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox