pg.ddx.io  GitHub: pgjdbc/pgjdbc (issues + PRs as email threads)  
help / color / mirror / Atom feed
From: vlsi (@vlsi) <noreply+vlsi@github.com>
To: pgjdbc/pgjdbc <noreply+pgjdbc-pgjdbc@github.com>
Subject: Re: [pgjdbc/pgjdbc] PR #4251: OAuth implementation
Date: Wed, 09 Sep 2026 15:45:36 +0000
Message-ID: <gh-pgjdbc-pgjdbc-4251-rc3970363331@github.com> (raw)
In-Reply-To: <gh-pgjdbc-pgjdbc-4251@github.com>
References: <gh-pgjdbc-pgjdbc-4251@github.com>

(on build-logic/jvm/src/main/kotlin/build-logic.test-base.gradle.kts)

`authMode` is missing from this list, so `oauth=all` cannot be reproduced outside CI. I ran `./gradlew :postgresql:test --tests '*DriverTest' -DauthMode=oauth` and got one skipped test out of eighteen, where the eight `assumeNotOAuthMode()` calls this PR adds to `DriverTest` should have skipped eight; inside the test JVM `authMode` is null.

In CI it works by accident: `main.yml` passes `matrix.extraJvmArgs` through `_JAVA_OPTIONS`, which every JVM picks up, including the forked test JVM. That also makes the `enable_oauth_tests` entry you added here redundant for CI and load-bearing for local runs, so `authMode` needs the same treatment.

Together with the `OAUTH` value mismatch in `docker/bin/postgres-server`, `oauth=all` cannot be reproduced locally at all, which is the mode that justifies editing nine existing test classes.

view thread (168+ messages)  latest in thread

Message-ID: <gh-pgjdbc-pgjdbc-4251-rc3970363331@github.com>
Permalink:  ../gh-pgjdbc-pgjdbc-4251-rc3970363331@github.com/

 · 


This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox