pg.ddx.io  GitHub: pgjdbc/pgjdbc (issues + PRs as email threads)  
help / color / mirror / Atom feed
From: vlsi (@vlsi) <noreply+vlsi@github.com>
To: pgjdbc/pgjdbc <noreply+pgjdbc-pgjdbc@github.com>
Subject: Re: [pgjdbc/pgjdbc] PR #4251: OAuth implementation
Date: Wed, 09 Sep 2026 15:45:36 +0000
Message-ID: <gh-pgjdbc-pgjdbc-4251-rc3970363353@github.com> (raw)
In-Reply-To: <gh-pgjdbc-pgjdbc-4251@github.com>
References: <gh-pgjdbc-pgjdbc-4251@github.com>

(on pgjdbc/src/test/java/org/postgresql/test/jdbc4/OAuthTest.java)

This asserts on a message the server produced, so it depends on the server's `lc_messages` and on how PostgreSQL 18 words this error in a given minor release. When a server upgrade changes the wording, the failure will point at the driver. `assertEquals("28000", ex.getSQLState())` is the stable form, with `ServerErrorMessage.getRoutine()` if you need to distinguish further.

This test is also the only coverage of the `AuthenticationSASLContinue` path, and it does not check that the path ran: `handleAuthenticationSASLContinue` could do nothing at all and the server would still send its `ErrorResponse`. `logHandler` is already wired up in this class, so asserting that the rejection record appeared would close that gap.

view thread (168+ messages)  latest in thread

Message-ID: <gh-pgjdbc-pgjdbc-4251-rc3970363353@github.com>
Permalink:  ../gh-pgjdbc-pgjdbc-4251-rc3970363353@github.com/

 · 


This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox