From: vlsi (@vlsi) <noreply+vlsi@github.com>
To: pgjdbc/pgjdbc <noreply+pgjdbc-pgjdbc@github.com>
Subject: Re: [pgjdbc/pgjdbc] PR #4251: OAuth implementation
Date: Wed, 09 Sep 2026 15:45:37 +0000
Message-ID: <gh-pgjdbc-pgjdbc-4251-rc3970363376@github.com> (raw)
In-Reply-To: <gh-pgjdbc-pgjdbc-4251@github.com>
References: <gh-pgjdbc-pgjdbc-4251@github.com>
(on testkit/src/main/java/org/postgresql/test/TestUtil.java)
Two constants name something other than what they hold.
`OAUTH_ISSUER` is the token endpoint. The issuer the server knows, from `entrypoint.sh`, is `http://keycloak:8080/realms/pgjdbc`, and `use.md` describes the property as "URL of the OAuth issuer (authorization server)". A test provider that treats the issuer as a URL to POST to will mislead the first person who copies it.
`OAUTH_CLIENT_SECRET` holds the password of user `testoauth` from `realm.json`, not a client secret.