From: vlsi (@vlsi) <noreply+vlsi@github.com>
To: pgjdbc/pgjdbc <noreply+pgjdbc-pgjdbc@github.com>
Subject: Re: [pgjdbc/pgjdbc] PR #4251: OAuth implementation
Date: Wed, 09 Sep 2026 15:45:37 +0000
Message-ID: <gh-pgjdbc-pgjdbc-4251-rc3970363386@github.com> (raw)
In-Reply-To: <gh-pgjdbc-pgjdbc-4251@github.com>
References: <gh-pgjdbc-pgjdbc-4251@github.com>
(on pgjdbc-mockito-test/src/test/java/org/postgresql/core/v3/ScramAuthenticatorChannelBindingTest.java:39)
Moving the `-PLUS` check into `initializeScramClient` gives `requireRejectsConnectionWithoutSsl` a second way to pass. That test asserts only `CONNECTION_REJECTED`, and the new check throws the same state, so dropping `SCRAM-SHA-256-PLUS` from this constant leaves the test green while it stops guarding the regression it was written for (GHSA-j92g-9f8w-j867). Its neighbour `requireRejectsCertificateWithoutChannelBindingHash` is safe, because it asserts on the message.
Asserting the message in that test, or a short comment here saying why `-PLUS` has to stay in this list, closes it.