From: vlsi (@vlsi) <noreply+vlsi@github.com>
To: pgjdbc/pgjdbc <noreply+pgjdbc-pgjdbc@github.com>
Subject: Re: [pgjdbc/pgjdbc] PR #4251: OAuth implementation
Date: Wed, 23 Sep 2026 06:43:33 +0000
Message-ID: <gh-pgjdbc-pgjdbc-4251-rc4079734532@github.com> (raw)
In-Reply-To: <gh-pgjdbc-pgjdbc-4251@github.com>
References: <gh-pgjdbc-pgjdbc-4251@github.com>
(on pgjdbc/src/main/java/org/postgresql/core/v3/ConnectionFactoryImpl.java:337)
An empty `oauthToken=` or `oauthTokenProviderClassName=` counts as "not configured" here, and mutation testing shows no test pins that down: removing both `isEmpty()` checks passes every test. That matters, because with both mechanisms offered an empty token would make OAUTHBEARER win and then fail. Please add the two empty-string rows to `SelectSaslMechanismTest`.