From: vlsi (@vlsi) <noreply+vlsi@github.com>
To: pgjdbc/pgjdbc <noreply+pgjdbc-pgjdbc@github.com>
Subject: Re: [pgjdbc/pgjdbc] PR #4251: OAuth implementation
Date: Wed, 23 Sep 2026 06:43:33 +0000
Message-ID: <gh-pgjdbc-pgjdbc-4251-rc4079734566@github.com> (raw)
In-Reply-To: <gh-pgjdbc-pgjdbc-4251@github.com>
References: <gh-pgjdbc-pgjdbc-4251@github.com>
(on pgjdbc/src/main/java/org/postgresql/core/v3/ConnectionFactoryImpl.java:1337)
The behavior is right and matches libpq's `check_expected_areq`, but this and the GSS changes above fix a defect from 42.7.11 (#3895) that affects SCRAM users without OAuth. Please move them to a separate PR so they can ship without the feature.
The call sites have no test. Putting `setFinishedAuthenticationRequests()` back into `enableGSSEncrypted`, or removing it from the JGSS branch, passes every test. `CheckAuthenticationCompletedTest` covers the predicate only.