pg.ddx.io  GitHub: pgjdbc/pgjdbc (issues + PRs as email threads)  
help / color / mirror / Atom feed
From: vlsi (@vlsi) <noreply+vlsi@github.com>
To: pgjdbc/pgjdbc <noreply+pgjdbc-pgjdbc@github.com>
Subject: Re: [pgjdbc/pgjdbc] PR #4251: OAuth implementation
Date: Wed, 23 Sep 2026 06:43:33 +0000
Message-ID: <gh-pgjdbc-pgjdbc-4251-rc4079734574@github.com> (raw)
In-Reply-To: <gh-pgjdbc-pgjdbc-4251@github.com>
References: <gh-pgjdbc-pgjdbc-4251@github.com>

(on pgjdbc/src/main/java/org/postgresql/core/v3/OAuthAuthenticator.java:73)

RFC 7628 §3 says only "TLS MUST be used for OAUTHBEARER to protect the bearer token". It says nothing about verifying the certificate or about GSS. Certificate validation is RFC 6750 §5.3 ("Validate TLS certificate chains"), whose "or equivalent transport security" also covers GSS. The same citation appears in `PGProperty`, `use.md`, and `CHANGELOG.md`.

Suggested text:

```
OAUTHBEARER sends the bearer token only to a verified server, and sslmode={0} does not verify the server certificate. Set sslmode=verify-full or verify-ca (RFC 6750 section 5.3).
```

For the unencrypted case, include the `sslmode` in effect (the usual cause is `prefer` falling back to plaintext) and leave `oauthAllowInsecureConnection` to the docs. Offering the escape hatch in the error contradicts `use.md`, which says the remedy is to raise `sslmode`. I'd also write "section" instead of `§` in `GT.tr` strings, since they end up in `.po` msgids and on consoles.

view thread (168+ messages)  latest in thread

Message-ID: <gh-pgjdbc-pgjdbc-4251-rc4079734574@github.com>
Permalink:  ../gh-pgjdbc-pgjdbc-4251-rc4079734574@github.com/

 · 


This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox