pg.ddx.io  GitHub: pgjdbc/pgjdbc (issues + PRs as email threads)  
help / color / mirror / Atom feed
From: vlsi (@vlsi) <noreply+vlsi@github.com>
To: pgjdbc/pgjdbc <noreply+pgjdbc-pgjdbc@github.com>
Subject: Re: [pgjdbc/pgjdbc] PR #4251: OAuth implementation
Date: Wed, 23 Sep 2026 06:43:34 +0000
Message-ID: <gh-pgjdbc-pgjdbc-4251-rc4079734614@github.com> (raw)
In-Reply-To: <gh-pgjdbc-pgjdbc-4251@github.com>
References: <gh-pgjdbc-pgjdbc-4251@github.com>

(on pgjdbc/src/main/java/org/postgresql/plugin/OAuthTokenRequest.java:22)

This class becomes public API, and a public four-argument constructor fixes its field set: adding a field later means another constructor or a break. A builder, or a constructor that isn't public (the driver is the only one that creates requests), keeps it open.

The fields are also too few for anything beyond a client-credentials flow against a fixed issuer. There is no host, port, user, or database, and with a multi-host URL a provider can't tell which host is being tried. Tokens from cloud identity providers are bound to exactly those values. Since discovery is planned for later, the issuer and scope the server advertises will need a place too.

The getters have only `@return` tags and no `@since`.

Please also rename the class to `OauthTokenRequest`, and `OAuthTokenProvider` to `OauthTokenProvider`, following the same camel-case rule as the setters ([Google Java Style ยง5.3](https://google.github.io/styleguide/javaguide.html#s5.3-camel-case)).

view thread (168+ messages)  latest in thread

Message-ID: <gh-pgjdbc-pgjdbc-4251-rc4079734614@github.com>
Permalink:  ../gh-pgjdbc-pgjdbc-4251-rc4079734614@github.com/

 · 


This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox