From: vlsi (@vlsi) <noreply+vlsi@github.com>
To: pgjdbc/pgjdbc <noreply+pgjdbc-pgjdbc@github.com>
Subject: Re: [pgjdbc/pgjdbc] PR #4251: OAuth implementation
Date: Wed, 23 Sep 2026 06:43:34 +0000
Message-ID: <gh-pgjdbc-pgjdbc-4251-rc4079734639@github.com> (raw)
In-Reply-To: <gh-pgjdbc-pgjdbc-4251@github.com>
References: <gh-pgjdbc-pgjdbc-4251@github.com>
(on pgjdbc/src/main/java/org/postgresql/ds/common/BaseDataSource.java:1519)
This is a compatibility break. I reproduced it with an encrypted client key: `copy.setURL(ds.getURL()); copy.setUser(ds.getUser())` connects on master and fails here with `Could not read password for SSL key file, console is not available.` Meanwhile `getReference()` and serialization still carry `sslpassword` and `oauthToken`, so the secret doesn't leave the DataSource anyway.
I'd keep `getUrl()` as it was and mask the URL where it is logged (`getConnection` logs it twice at FINE). If you keep the change, it needs a `**Breaking:**` changelog entry and its own commit.