pg.ddx.io  GitHub: pgjdbc/pgjdbc (issues + PRs as email threads)  
help / color / mirror / Atom feed
From: vlsi (@vlsi) <noreply+vlsi@github.com>
To: pgjdbc/pgjdbc <noreply+pgjdbc-pgjdbc@github.com>
Subject: Re: [pgjdbc/pgjdbc] PR #4251: OAuth implementation
Date: Wed, 23 Sep 2026 06:43:34 +0000
Message-ID: <gh-pgjdbc-pgjdbc-4251-rc4079734646@github.com> (raw)
In-Reply-To: <gh-pgjdbc-pgjdbc-4251@github.com>
References: <gh-pgjdbc-pgjdbc-4251@github.com>

(on pgjdbc/src/main/java/org/postgresql/ds/common/BaseDataSource.java:122)

This method has 0% coverage, and dropping every credential it copies passes every test: `setOAuthToken`, `setSslPassword`, and `setOAuthClientSecret` would stop working silently. A test that connects a `PGSimpleDataSource` with `setOAuthToken(...)` to the `OAuthHandshakeTest` fake backend and checks the token in the SASLInitialResponse would pin it down.

view thread (168+ messages)  latest in thread

Message-ID: <gh-pgjdbc-pgjdbc-4251-rc4079734646@github.com>
Permalink:  ../gh-pgjdbc-pgjdbc-4251-rc4079734646@github.com/

 · 


This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox