From: vlsi (@vlsi) <noreply+vlsi@github.com>
To: pgjdbc/pgjdbc <noreply+pgjdbc-pgjdbc@github.com>
Subject: Re: [pgjdbc/pgjdbc] PR #4251: OAuth implementation
Date: Wed, 23 Sep 2026 06:43:34 +0000
Message-ID: <gh-pgjdbc-pgjdbc-4251-rc4079734655@github.com> (raw)
In-Reply-To: <gh-pgjdbc-pgjdbc-4251@github.com>
References: <gh-pgjdbc-pgjdbc-4251@github.com>
(on pgjdbc/src/main/java/org/postgresql/ds/common/BaseDataSource.java:1608)
HikariCP's `PropertyElf` derives `setOauthToken` from `dataSource.oauthToken`, so with `dataSourceClassName=org.postgresql.ds.PGSimpleDataSource` the pool fails at start:
```
java.lang.RuntimeException: Property oauthToken does not exist on target class org.postgresql.ds.PGSimpleDataSource
```
The same happens with `hikari.properties`. Only `dataSource.OAuthToken` works. This affects all eight new setters. Since none of them has been released, please rename them rather than add aliases: `get/setOauthToken`, `get/setOauthTokenProviderClassName`, `get/setOauthIssuer`, `get/setOauthClientId`, `get/setOauthClientSecret`, `get/setOauthScope`, `get/setOauthAllowInsecureConnection`, `get/setOauthAllowInsecureIssuer`. That is what `java.beans.Introspector` derives from `oauthToken`, and it follows [Google Java Style ยง5.3](https://google.github.io/styleguide/javaguide.html#s5.3-camel-case), as `setSslMode` and `setGssResponseTimeout` do. `PGPropertyTest.dataSourceProperties` didn't catch it because it compares names with `CASE_INSENSITIVE_ORDER`; it should also check the exact setter name HikariCP looks up.