From: vlsi (@vlsi) <noreply+vlsi@github.com>
To: pgjdbc/pgjdbc <noreply+pgjdbc-pgjdbc@github.com>
Subject: Re: [pgjdbc/pgjdbc] PR #4251: OAuth implementation
Date: Wed, 23 Sep 2026 06:43:34 +0000
Message-ID: <gh-pgjdbc-pgjdbc-4251-rc4079734700@github.com> (raw)
In-Reply-To: <gh-pgjdbc-pgjdbc-4251@github.com>
References: <gh-pgjdbc-pgjdbc-4251@github.com>
(on docs/content/documentation/use.md:598)
Three of these four sentences explain the mechanism and defend it. The consequence the reader needs is missing: with `sslmode=verify-ca` or `verify-full` and a factory that doesn't validate, the token goes to an unverified server, and nothing is logged. Suggested: "With a custom `sslfactory`, the driver trusts `sslmode` and does not inspect the factory. A factory that skips validation, such as `org.postgresql.ssl.NonValidatingFactory`, sends the token to an unverified server without a warning." The `sslfactory` entry needs a matching sentence.