pg.ddx.io  GitHub: pgjdbc/pgjdbc (issues + PRs as email threads)  
help / color / mirror / Atom feed
From: vlsi (@vlsi) <noreply+vlsi@github.com>
To: pgjdbc/pgjdbc <noreply+pgjdbc-pgjdbc@github.com>
Subject: Re: [pgjdbc/pgjdbc] PR #4251: OAuth implementation
Date: Wed, 23 Sep 2026 06:43:34 +0000
Message-ID: <gh-pgjdbc-pgjdbc-4251-rc4079734713@github.com> (raw)
In-Reply-To: <gh-pgjdbc-pgjdbc-4251@github.com>
References: <gh-pgjdbc-pgjdbc-4251@github.com>

(on CHANGELOG.md)

"`password` was never affected" isn't true for a `password` in the JDBC URL. On master, `Driver` logs the URL verbatim at WARNING (`JDBC URL contains too many / characters: {0}`, `JDBC URL must contain a / at the end of the host or port: {0}`), at FINE (`Connecting with URL: {0}`), and in the `Unable to parse URL {0}` exception. That is the leak released users have, and this entry doesn't mention it.

`oauthToken` and `oauthClientSecret` were never released, so no upgrading user was affected by them. The `getUrl()` change needs a `**Breaking:**` marker and its own entry, or better, see the comment on `BaseDataSource.getUrl()`.

view thread (168+ messages)  latest in thread

Message-ID: <gh-pgjdbc-pgjdbc-4251-rc4079734713@github.com>
Permalink:  ../gh-pgjdbc-pgjdbc-4251-rc4079734713@github.com/

 · 


This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox