From: vlsi (@vlsi) <noreply+vlsi@github.com>
To: pgjdbc/pgjdbc <noreply+pgjdbc-pgjdbc@github.com>
Subject: Re: [pgjdbc/pgjdbc] PR #4251: OAuth implementation
Date: Wed, 23 Sep 2026 06:43:34 +0000
Message-ID: <gh-pgjdbc-pgjdbc-4251-rc4079734728@github.com> (raw)
In-Reply-To: <gh-pgjdbc-pgjdbc-4251@github.com>
References: <gh-pgjdbc-pgjdbc-4251@github.com>
(on pgjdbc/src/test/java/org/postgresql/core/v3/SelectSaslMechanismTest.java:73)
Several tests here make two or more calls with different inputs and assert after each (for example lines 74-79, 100-105, 108-114, 160-167, 170-177), so one failure hides the rest, and the name has to cover several cases. The function is a pure decision over offered mechanisms × `requireAuth` × configured × `channelBinding`, which reads best as one `@ParameterizedTest` table with a named row per case.
Missing rows: empty `oauthToken=` and `oauthTokenProviderClassName=` (a surviving mutant), a server offering only `SCRAM-SHA-256-PLUS`, and one offering `PLAIN` with `OAUTHBEARER`.