From: vlsi (@vlsi) <noreply+vlsi@github.com>
To: pgjdbc/pgjdbc <noreply+pgjdbc-pgjdbc@github.com>
Subject: Re: [pgjdbc/pgjdbc] PR #4251: OAuth implementation
Date: Wed, 23 Sep 2026 06:43:35 +0000
Message-ID: <gh-pgjdbc-pgjdbc-4251-rc4079734740@github.com> (raw)
In-Reply-To: <gh-pgjdbc-pgjdbc-4251@github.com>
References: <gh-pgjdbc-pgjdbc-4251@github.com>
(on pgjdbc/src/test/java/org/postgresql/test/jdbc4/OAuthTest.java:214)
This test and `unverifiedTlsConnectionRejected` and `requireAuthForbidsOAuth` assert only `CONNECTION_REJECTED`, which five other failures share (for example "no password was provided"), so they can pass for the wrong reason. Please assert something specific to the cause as well. `staticToken`, `tokenProvider`, and `invalidToken` are names without an outcome, for example `connectsWithAStaticToken` and `refusesATokenTheValidatorRejects`.