pg.ddx.io  GitHub: pgjdbc/pgjdbc (issues + PRs as email threads)  
help / color / mirror / Atom feed
From: vlsi (@vlsi) <noreply+vlsi@github.com>
To: pgjdbc/pgjdbc <noreply+pgjdbc-pgjdbc@github.com>
Subject: Re: [pgjdbc/pgjdbc] PR #4332 (changes requested): fix: limit FINEST Bind, Parse and SimpleQuery log messages to maxLogMessageLength to avoid OOM
Date: Wed, 14 Oct 2026 06:22:28 +0000
Message-ID: <gh-pgjdbc-pgjdbc-4332-r5513846327@github.com> (raw)
In-Reply-To: <gh-pgjdbc-pgjdbc-4332@github.com>
References: <gh-pgjdbc-pgjdbc-4332@github.com>

These points of the previous review are still open: the unbounded `SimpleQuery` trace, the test on a live connection, the negative `maxLogMessageLength`, the `CHANGELOG.md` entry, and the merge commit. `BindLogTest` still imports `assertEquals` without using it, and the new `LogMessageUtils` import in `QueryExecutorImpl` is out of order, so `autostyleJavaCheck` and `checkstyleMain` fail.

`README.md` lists connection properties in a table, and the other logging properties, `logServerErrorDetail` and `logUnclosedConnections`, have a row there. Please add a row for `maxLogMessageLength`.

Smaller points:

- The class comment of `BindLogTest` names the subject, not the rule the tests check. For example: "A Bind trace is never longer than `maxLogMessageLength`, and with no limit it matches the format logged before the limit existed."
- `logging.md` has two blank lines before `## Configuration`; one is enough.
- The test command in the PR description names `org.postgresql.util.LogMessageUtilsTest`; the class is now in `org.postgresql.util.internal`.

view thread (58+ messages)  latest in thread

Message-ID: <gh-pgjdbc-pgjdbc-4332-r5513846327@github.com>
Permalink:  ../gh-pgjdbc-pgjdbc-4332-r5513846327@github.com/

 · 


This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox