From: vlsi (@vlsi) <noreply+vlsi@github.com>
To: pgjdbc/pgjdbc <noreply+pgjdbc-pgjdbc@github.com>
Subject: Re: [pgjdbc/pgjdbc] PR #4332: fix: limit FINEST Bind, Parse and SimpleQuery log messages to maxLogMessageLength to avoid OOM
Date: Wed, 14 Oct 2026 02:52:58 +0000
Message-ID: <gh-pgjdbc-pgjdbc-4332-rc4266276849@github.com> (raw)
In-Reply-To: <gh-pgjdbc-pgjdbc-4332@github.com>
References: <gh-pgjdbc-pgjdbc-4332@github.com>
(on pgjdbc/src/test/java/org/postgresql/core/v3/BindLogTest.java)
This passes for a trace that lost parameters without a marker. With `maxLen = 512` the trace is 512 characters ending `,$5=<...(~88 chars)>,type=VARCHAR)`: `log.length() < maxLen` is false, but `log.contains("...")` matches the `...(~88 chars)` placeholder. Please assert `log.endsWith(LogMessageUtils.TRUNCATION_SUFFIX)`, and remove the comment above, which allows a trace to stop between parameters with no suffix.