pg.ddx.io  GitHub: pgjdbc/pgjdbc (issues + PRs as email threads)  
help / color / mirror / Atom feed
From: vlsi (@vlsi) <noreply+vlsi@github.com>
To: pgjdbc/pgjdbc <noreply+pgjdbc-pgjdbc@github.com>
Subject: Re: [pgjdbc/pgjdbc] PR #4332: fix: limit FINEST Bind, Parse and SimpleQuery log messages to maxLogMessageLength to avoid OOM
Date: Wed, 14 Oct 2026 06:22:27 +0000
Message-ID: <gh-pgjdbc-pgjdbc-4332-rc4267444406@github.com> (raw)
In-Reply-To: <gh-pgjdbc-pgjdbc-4332@github.com>
References: <gh-pgjdbc-pgjdbc-4332@github.com>

(on pgjdbc/src/test/java/org/postgresql/core/v3/BindLogTest.java)

These assertions pass when the trace drops `,type=…`, shows the first parameter's value for every `$i`, or, in `unlimitedKeepsFullDump`, shows no values at all. On failure they print `expected: <true> but was: <false>` without the trace. The whole line is known here, and under the limit it must match the format logged before this PR, so please compare it with a literal: `assertEquals(" FE=> Bind(stmt=S_1,portal=null,$1=<('1'::int4)>,type=INT4,$2=<('2'::int4)>,type=INT4)", log)`. The same applies to `unlimitedKeepsFullDump` at line 185 and to the newer tests: line 87 passes on the `...` of `...(truncated)`, and lines 166-167 accept the marker anywhere in the line.

view thread (58+ messages)  latest in thread

Message-ID: <gh-pgjdbc-pgjdbc-4332-rc4267444406@github.com>
Permalink:  ../gh-pgjdbc-pgjdbc-4332-rc4267444406@github.com/

 · 


This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox