pg.ddx.io  GitHub: pgjdbc/pgjdbc (issues + PRs as email threads)  
help / color / mirror / Atom feed
From: vlsi (@vlsi) <noreply+vlsi@github.com>
To: pgjdbc/pgjdbc <noreply+pgjdbc-pgjdbc@github.com>
Subject: Re: [pgjdbc/pgjdbc] PR #4332: fix: limit FINEST Bind, Parse and SimpleQuery log messages to maxLogMessageLength to avoid OOM
Date: Wed, 14 Oct 2026 06:22:28 +0000
Message-ID: <gh-pgjdbc-pgjdbc-4332-rc4267444503@github.com> (raw)
In-Reply-To: <gh-pgjdbc-pgjdbc-4332@github.com>
References: <gh-pgjdbc-pgjdbc-4332@github.com>

(on pgjdbc/src/main/java/org/postgresql/PGProperty.java)

The project's word list in `AGENTS.md` asks for "limit" instead of "cap". Please use it in `logging.md` ("capped"), the class comments of `BindLog`, `LogMessageUtils`, and `BindLogTest`, the field comment in `QueryExecutorImpl`, the `stringValueForLog` Javadoc, the `@param maxLength` tags in `LogMessageUtils`, the test name `manyBindsAreCapped`, and the assertion messages in `BindLogTest`. In `BindLog`, replace "a hard length cap so large or numerous bind parameters cannot OOM the process" with what the limit does. Here, "Max length" should be "Maximum length", and the description, which tools show on one line, can drop the list of traces the property does not bound; `use.md` carries it.

view thread (58+ messages)  latest in thread

Message-ID: <gh-pgjdbc-pgjdbc-4332-rc4267444503@github.com>
Permalink:  ../gh-pgjdbc-pgjdbc-4332-rc4267444503@github.com/

 · 


This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox