pg.ddx.io  GitHub: pgjdbc/pgjdbc (issues + PRs as email threads)  
help / color / mirror / Atom feed
From: vlsi (@vlsi) <noreply+vlsi@github.com>
To: pgjdbc/pgjdbc <noreply+pgjdbc-pgjdbc@github.com>
Subject: Re: [pgjdbc/pgjdbc] PR #4512 (changes requested): fix: mask credentials in the JDBC URLs the driver logs
Date: Thu, 05 Nov 2026 12:10:27 +0000
Message-ID: <gh-pgjdbc-pgjdbc-4512-r5784690723@github.com> (raw)
In-Reply-To: <gh-pgjdbc-pgjdbc-4512@github.com>
References: <gh-pgjdbc-pgjdbc-4512@github.com>

Severity: please fix major and minor before merge. nit is up to you; if you skip one, a short reply saying why is enough.

[follow-up] `pgjdbc/src/main/java/org/postgresql/jdbcurlresolver/PgServiceConfParser.java:239` logs an invalid line of `pg_service.conf` whole: a line whose key is not recognized at `SEVERE` (line 239), and a line without `=` at `WARNING` (line 252). `password = s3cret` takes that path: the space before `=` makes the key `password `, so the password reaches the log. It is outside this PR's diff; a follow-up issue would keep it from being lost.

view thread (25+ messages)  latest in thread

Message-ID: <gh-pgjdbc-pgjdbc-4512-r5784690723@github.com>
Permalink:  ../gh-pgjdbc-pgjdbc-4512-r5784690723@github.com/

 · 


This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox