From: vlsi (@vlsi) <noreply+vlsi@github.com>
To: pgjdbc/pgjdbc <noreply+pgjdbc-pgjdbc@github.com>
Subject: Re: [pgjdbc/pgjdbc] PR #4512: fix: mask credentials in the JDBC URLs the driver logs
Date: Thu, 05 Nov 2026 12:10:27 +0000
Message-ID: <gh-pgjdbc-pgjdbc-4512-rc4480244923@github.com> (raw)
In-Reply-To: <gh-pgjdbc-pgjdbc-4512@github.com>
References: <gh-pgjdbc-pgjdbc-4512@github.com>
(on pgjdbc/src/main/java/org/postgresql/PGProperty.java)
**nit**: the sensitive set is declared 500 lines away from the properties
`SENSITIVE_PROPERTIES` sits far from `PASSWORD(` and `SSL_PASSWORD(`, and nothing reminds the author of a new property to classify it; #4251 already has to add `OAUTH_TOKEN` and `OAUTH_CLIENT_SECRET` here. A constructor flag next to `required` would put the decision where the property is declared.