From: vlsi (@vlsi) <noreply+vlsi@github.com>
To: pgjdbc/pgjdbc <noreply+pgjdbc-pgjdbc@github.com>
Subject: Re: [pgjdbc/pgjdbc] PR #4512: fix: mask credentials in the JDBC URLs the driver logs
Date: Thu, 05 Nov 2026 12:10:27 +0000
Message-ID: <gh-pgjdbc-pgjdbc-4512-rc4480244930@github.com> (raw)
In-Reply-To: <gh-pgjdbc-pgjdbc-4512@github.com>
References: <gh-pgjdbc-pgjdbc-4512@github.com>
(on pgjdbc/src/test/java/org/postgresql/util/PGPropertyUtilTest.java)
**nit**: an empty password is shown as `***`
`password=` (empty) disables the `.pgpass` lookup (`Driver.parseURL` reads `.pgpass` only when the password is `null`), and the log then shows `password=***`, which tells someone debugging an authentication failure that a password was set. An empty value discloses nothing; please leave it as `password=`.