From: vlsi (@vlsi) <noreply+vlsi@github.com>
To: pgjdbc/pgjdbc <noreply+pgjdbc-pgjdbc@github.com>
Subject: Re: [pgjdbc/pgjdbc] PR #4512: fix: mask credentials in the JDBC URLs the driver logs
Date: Thu, 05 Nov 2026 12:10:27 +0000
Message-ID: <gh-pgjdbc-pgjdbc-4512-rc4480244936@github.com> (raw)
In-Reply-To: <gh-pgjdbc-pgjdbc-4512@github.com>
References: <gh-pgjdbc-pgjdbc-4512@github.com>
(on pgjdbc/src/test/java/org/postgresql/test/jdbc2/PGPropertyTest.java)
**nit**: test placement and shape
- The tests exercise `Driver.parseURL`, `Driver.connect`, and `BaseDataSource`, not `PGProperty`; `DriverTest` already tests `parseURL` and bad URLs (`badUrlsTest`, `rejectsBadUrls`).
- `masksUnusualQueryString` checks four cases in one method, and the first failure hides the rest; a `@ParameterizedTest` with named rows reports each one.