pgjdbc/pgjdbc GitHub issues and pull requests (mirror)
help / color / mirror / Atom feedFrom: tordmjohnson (@tordmjohnson) <[email protected]>
To: pgjdbc/pgjdbc <[email protected]>
Subject: Re: [pgjdbc/pgjdbc] PR #943: fix: synchronize modification of shared calendar (#921)
Date: Sun, 22 Oct 2017 01:46:36 +0000
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
OK, I've made `TimestampUtils#getSharedCalendar(TimeZone)` private, and pushed all the dependent code from `PgResultSet` and `PgPreparedStatement` down into `TimestampUtils`. This was an initial, more-or-less straight forward transformation, and could probably use some refactoring, but didn't want to mix objectives with this initial set of changes.
For example, it seems unnecessary to keep a second cached `defaultTimeZone` in `TimestampUtils`, but it wasn't exactly clear to me why it was being cleared after some calls, such as from `PgPreparedStatement#executeBatch()`.
Would you like me to continue, to go on and refactor a bit, such as removing the seemingly redundant `TimestampUtils.defaultTimeZone`? Or should I just stop here? Thanks for any guidance.
view thread (29+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: github://pgjdbc/pgjdbc
Cc: [email protected], [email protected]
Subject: Re: [pgjdbc/pgjdbc] PR #943: fix: synchronize modification of shared calendar (#921)
In-Reply-To: <<[email protected]>>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox