agora inbox for pgpool-committers@postgresql.orghelp / color / mirror / Atom feed
pgpool: Fix duplicate NodeTag enum in nodes.h. 4+ messages / 1 participants [nested] [flat]
* pgpool: Fix duplicate NodeTag enum in nodes.h. @ 2025-12-24 08:05 Tatsuo Ishii <ishii@postgresql.org> 0 siblings, 0 replies; 4+ messages in thread From: Tatsuo Ishii @ 2025-12-24 08:05 UTC (permalink / raw) To: pgpool-committers@lists.postgresql.org Fix duplicate NodeTag enum in nodes.h. The file was imported from PostgreSQL and Pgpool-II specific node type were added right after T_Invalid = 0, then nodetags.h is included. Since nodetags.h explicitly assign values to each enum starting from 1, and this created duplicated enums. T_List = 1, T_Alias = 2, T_RangeVar = 3, T_PgpoolVariableSetStmt, (1) T_PgpoolVariableShowStmt, (2) T_PgpoolQueryCacheStmt, (3) Although fortunately this seems does not create any trouble except the duplicated enums, this should be fixed: moving the inclusion of nodetags.h right after "T_invalid = 0". Reported-by: liujinyang-highgo Diagnosed-by: liujinyang-highgo Discussion: https://github.com/pgpool/pgpool2/issues/138 Backpatch-through: v4.5 Branch ------ V4_5_STABLE Details ------- https://git.postgresql.org/gitweb?p=pgpool2.git;a=commitdiff;h=6e4f664a5c2e4961029eada15258a7a118096... Modified Files -------------- src/include/parser/nodes.h | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) ^ permalink raw reply [nested|flat] 4+ messages in thread
* pgpool: Fix duplicate NodeTag enum in nodes.h. @ 2025-12-24 08:06 Tatsuo Ishii <ishii@postgresql.org> 0 siblings, 0 replies; 4+ messages in thread From: Tatsuo Ishii @ 2025-12-24 08:06 UTC (permalink / raw) To: pgpool-committers@lists.postgresql.org Fix duplicate NodeTag enum in nodes.h. The file was imported from PostgreSQL and Pgpool-II specific node type were added right after T_Invalid = 0, then nodetags.h is included. Since nodetags.h explicitly assign values to each enum starting from 1, and this created duplicated enums. T_List = 1, T_Alias = 2, T_RangeVar = 3, T_PgpoolVariableSetStmt, (1) T_PgpoolVariableShowStmt, (2) T_PgpoolQueryCacheStmt, (3) Although fortunately this seems does not create any trouble except the duplicated enums, this should be fixed: moving the inclusion of nodetags.h right after "T_invalid = 0". Reported-by: liujinyang-highgo Diagnosed-by: liujinyang-highgo Discussion: https://github.com/pgpool/pgpool2/issues/138 Backpatch-through: v4.5 Branch ------ V4_6_STABLE Details ------- https://git.postgresql.org/gitweb?p=pgpool2.git;a=commitdiff;h=9fcc5ba684c1b5c71759d563dd3caabd0cadd... Modified Files -------------- src/include/parser/nodes.h | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) ^ permalink raw reply [nested|flat] 4+ messages in thread
* pgpool: Fix duplicate NodeTag enum in nodes.h. @ 2025-12-24 08:06 Tatsuo Ishii <ishii@postgresql.org> 0 siblings, 0 replies; 4+ messages in thread From: Tatsuo Ishii @ 2025-12-24 08:06 UTC (permalink / raw) To: pgpool-committers@lists.postgresql.org Fix duplicate NodeTag enum in nodes.h. The file was imported from PostgreSQL and Pgpool-II specific node type were added right after T_Invalid = 0, then nodetags.h is included. Since nodetags.h explicitly assign values to each enum starting from 1, and this created duplicated enums. T_List = 1, T_Alias = 2, T_RangeVar = 3, T_PgpoolVariableSetStmt, (1) T_PgpoolVariableShowStmt, (2) T_PgpoolQueryCacheStmt, (3) Although fortunately this seems does not create any trouble except the duplicated enums, this should be fixed: moving the inclusion of nodetags.h right after "T_invalid = 0". Reported-by: liujinyang-highgo Diagnosed-by: liujinyang-highgo Discussion: https://github.com/pgpool/pgpool2/issues/138 Backpatch-through: v4.5 Branch ------ V4_7_STABLE Details ------- https://git.postgresql.org/gitweb?p=pgpool2.git;a=commitdiff;h=9acb78c01471caf70394ee7b5549ec50bec48... Modified Files -------------- src/include/parser/nodes.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) ^ permalink raw reply [nested|flat] 4+ messages in thread
* pgpool: Fix duplicate NodeTag enum in nodes.h. @ 2025-12-24 08:06 Tatsuo Ishii <ishii@postgresql.org> 0 siblings, 0 replies; 4+ messages in thread From: Tatsuo Ishii @ 2025-12-24 08:06 UTC (permalink / raw) To: pgpool-committers@lists.postgresql.org Fix duplicate NodeTag enum in nodes.h. The file was imported from PostgreSQL and Pgpool-II specific node type were added right after T_Invalid = 0, then nodetags.h is included. Since nodetags.h explicitly assign values to each enum starting from 1, and this created duplicated enums. T_List = 1, T_Alias = 2, T_RangeVar = 3, T_PgpoolVariableSetStmt, (1) T_PgpoolVariableShowStmt, (2) T_PgpoolQueryCacheStmt, (3) Although fortunately this seems does not create any trouble except the duplicated enums, this should be fixed: moving the inclusion of nodetags.h right after "T_invalid = 0". Reported-by: liujinyang-highgo Diagnosed-by: liujinyang-highgo Discussion: https://github.com/pgpool/pgpool2/issues/138 Backpatch-through: v4.5 Branch ------ master Details ------- https://git.postgresql.org/gitweb?p=pgpool2.git;a=commitdiff;h=27bc3ceb418c1d6bb83c21e5fffb4f03b27b1... Modified Files -------------- src/include/parser/nodes.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) ^ permalink raw reply [nested|flat] 4+ messages in thread
end of thread, other threads:[~2025-12-24 08:06 UTC | newest] Thread overview: 4+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2025-12-24 08:05 pgpool: Fix duplicate NodeTag enum in nodes.h. Tatsuo Ishii <ishii@postgresql.org> 2025-12-24 08:06 pgpool: Fix duplicate NodeTag enum in nodes.h. Tatsuo Ishii <ishii@postgresql.org> 2025-12-24 08:06 pgpool: Fix duplicate NodeTag enum in nodes.h. Tatsuo Ishii <ishii@postgresql.org> 2025-12-24 08:06 pgpool: Fix duplicate NodeTag enum in nodes.h. Tatsuo Ishii <ishii@postgresql.org>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox