agora inbox for pgpool-committers@postgresql.orghelp / color / mirror / Atom feed
pgpool: Fix walker functions to return earlier. 6+ messages / 1 participants [nested] [flat]
* pgpool: Fix walker functions to return earlier. @ 2026-01-22 04:30 Tatsuo Ishii <ishii@postgresql.org> 0 siblings, 0 replies; 6+ messages in thread From: Tatsuo Ishii @ 2026-01-22 04:30 UTC (permalink / raw) To: pgpool-committers@lists.postgresql.org Fix walker functions to return earlier. Previously walker functions returned false once it found target objects. But it is possible to short-circuit the traverse and it should have been. Also import comments from PostgreSQL to clarify walker function design. Author: Tatsuo Ishii <ishii@postgresql.org> Reported-by: liujinyang-highgo Backpatch-through: v4.3 Discussion: https://github.com/pgpool/pgpool2/issues/143 Branch ------ V4_3_STABLE Details ------- https://git.postgresql.org/gitweb?p=pgpool2.git;a=commitdiff;h=64dda20f0070a6c64adb61433c07f89ea1c64... Modified Files -------------- src/rewrite/pool_timestamp.c | 40 +++++++++++++++++++++++++++++++++++++++- src/utils/pool_select_walker.c | 18 +++++++++--------- 2 files changed, 48 insertions(+), 10 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgpool: Fix walker functions to return earlier. @ 2026-01-22 04:30 Tatsuo Ishii <ishii@postgresql.org> 0 siblings, 0 replies; 6+ messages in thread From: Tatsuo Ishii @ 2026-01-22 04:30 UTC (permalink / raw) To: pgpool-committers@lists.postgresql.org Fix walker functions to return earlier. Previously walker functions returned false once it found target objects. But it is possible to short-circuit the traverse and it should have been. Also import comments from PostgreSQL to clarify walker function design. Author: Tatsuo Ishii <ishii@postgresql.org> Reported-by: liujinyang-highgo Backpatch-through: v4.3 Discussion: https://github.com/pgpool/pgpool2/issues/143 Branch ------ V4_4_STABLE Details ------- https://git.postgresql.org/gitweb?p=pgpool2.git;a=commitdiff;h=10c9a008bfe9e34b9dace21c802f8b16a669c... Modified Files -------------- src/rewrite/pool_timestamp.c | 40 +++++++++++++++++++++++++++++++++++++++- src/utils/pool_select_walker.c | 18 +++++++++--------- 2 files changed, 48 insertions(+), 10 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgpool: Fix walker functions to return earlier. @ 2026-01-22 04:30 Tatsuo Ishii <ishii@postgresql.org> 0 siblings, 0 replies; 6+ messages in thread From: Tatsuo Ishii @ 2026-01-22 04:30 UTC (permalink / raw) To: pgpool-committers@lists.postgresql.org Fix walker functions to return earlier. Previously walker functions returned false once it found target objects. But it is possible to short-circuit the traverse and it should have been. Also import comments from PostgreSQL to clarify walker function design. Author: Tatsuo Ishii <ishii@postgresql.org> Reported-by: liujinyang-highgo Backpatch-through: v4.3 Discussion: https://github.com/pgpool/pgpool2/issues/143 Branch ------ V4_5_STABLE Details ------- https://git.postgresql.org/gitweb?p=pgpool2.git;a=commitdiff;h=fae3109be1fc42da681ec8fa0589701a26483... Modified Files -------------- src/rewrite/pool_timestamp.c | 40 +++++++++++++++++++++++++++++++++++++++- src/utils/pool_select_walker.c | 18 +++++++++--------- 2 files changed, 48 insertions(+), 10 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgpool: Fix walker functions to return earlier. @ 2026-01-22 04:30 Tatsuo Ishii <ishii@postgresql.org> 0 siblings, 0 replies; 6+ messages in thread From: Tatsuo Ishii @ 2026-01-22 04:30 UTC (permalink / raw) To: pgpool-committers@lists.postgresql.org Fix walker functions to return earlier. Previously walker functions returned false once it found target objects. But it is possible to short-circuit the traverse and it should have been. Also import comments from PostgreSQL to clarify walker function design. Author: Tatsuo Ishii <ishii@postgresql.org> Reported-by: liujinyang-highgo Backpatch-through: v4.3 Discussion: https://github.com/pgpool/pgpool2/issues/143 Branch ------ V4_6_STABLE Details ------- https://git.postgresql.org/gitweb?p=pgpool2.git;a=commitdiff;h=0fdeee9d23447543e096274b05f9714a8e218... Modified Files -------------- src/rewrite/pool_timestamp.c | 40 +++++++++++++++++++++++++++++++++++++++- src/utils/pool_select_walker.c | 18 +++++++++--------- 2 files changed, 48 insertions(+), 10 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgpool: Fix walker functions to return earlier. @ 2026-01-22 04:30 Tatsuo Ishii <ishii@postgresql.org> 0 siblings, 0 replies; 6+ messages in thread From: Tatsuo Ishii @ 2026-01-22 04:30 UTC (permalink / raw) To: pgpool-committers@lists.postgresql.org Fix walker functions to return earlier. Previously walker functions returned false once it found target objects. But it is possible to short-circuit the traverse and it should have been. Also import comments from PostgreSQL to clarify walker function design. Author: Tatsuo Ishii <ishii@postgresql.org> Reported-by: liujinyang-highgo Backpatch-through: v4.3 Discussion: https://github.com/pgpool/pgpool2/issues/143 Branch ------ V4_7_STABLE Details ------- https://git.postgresql.org/gitweb?p=pgpool2.git;a=commitdiff;h=c0f2cb883fafe32ed26034ae6be0a4634a959... Modified Files -------------- src/rewrite/pool_timestamp.c | 40 +++++++++++++++++++++++++++++++++++++++- src/utils/pool_select_walker.c | 18 +++++++++--------- 2 files changed, 48 insertions(+), 10 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgpool: Fix walker functions to return earlier. @ 2026-01-22 04:30 Tatsuo Ishii <ishii@postgresql.org> 0 siblings, 0 replies; 6+ messages in thread From: Tatsuo Ishii @ 2026-01-22 04:30 UTC (permalink / raw) To: pgpool-committers@lists.postgresql.org Fix walker functions to return earlier. Previously walker functions returned false once it found target objects. But it is possible to short-circuit the traverse and it should have been. Also import comments from PostgreSQL to clarify walker function design. Author: Tatsuo Ishii <ishii@postgresql.org> Reported-by: liujinyang-highgo Backpatch-through: v4.3 Discussion: https://github.com/pgpool/pgpool2/issues/143 Branch ------ master Details ------- https://git.postgresql.org/gitweb?p=pgpool2.git;a=commitdiff;h=747358a97a39568e9a8ba5b6433fa464e2215... Modified Files -------------- src/rewrite/pool_timestamp.c | 40 +++++++++++++++++++++++++++++++++++++++- src/utils/pool_select_walker.c | 18 +++++++++--------- 2 files changed, 48 insertions(+), 10 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
end of thread, other threads:[~2026-01-22 04:30 UTC | newest] Thread overview: 6+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2026-01-22 04:30 pgpool: Fix walker functions to return earlier. Tatsuo Ishii <ishii@postgresql.org> 2026-01-22 04:30 pgpool: Fix walker functions to return earlier. Tatsuo Ishii <ishii@postgresql.org> 2026-01-22 04:30 pgpool: Fix walker functions to return earlier. Tatsuo Ishii <ishii@postgresql.org> 2026-01-22 04:30 pgpool: Fix walker functions to return earlier. Tatsuo Ishii <ishii@postgresql.org> 2026-01-22 04:30 pgpool: Fix walker functions to return earlier. Tatsuo Ishii <ishii@postgresql.org> 2026-01-22 04:30 pgpool: Fix walker functions to return earlier. Tatsuo Ishii <ishii@postgresql.org>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox