agora inbox for pgpool-committers@postgresql.orghelp / color / mirror / Atom feed
pgpool: Fix pool_do_auth. 6+ messages / 1 participants [nested] [flat]
* pgpool: Fix pool_do_auth. @ 2026-08-15 05:05 Tatsuo Ishii <ishii@postgresql.org> 0 siblings, 0 replies; 6+ messages in thread From: Tatsuo Ishii @ 2026-08-15 05:05 UTC (permalink / raw) To: pgpool-committers@lists.postgresql.org Fix pool_do_auth. From PostgreSQL 19, backend sends a notice message "authenticated with an MD5-encrypted password" if MD5 auth is used. Unfortunately it exercises an untested code path in pool_do_auth. It calls SimpleForwardToFrontend to forward the notice message to frontend. Unfortunately calling it in authentication phase is wrong, since "session contest" is not established yet. If the session context is not established, SimpleForwardToFrontend fails with FATAL. To fix this, create a new function "forward_message_to_frontend", which is basically a simple version of SimpleForwardToFrontend error, so that it does not raise the FATAL error. Also add 083.md5_warning test for this. Reported-by: harudini Author: Tatsuo Ishii <ishii@postgresql.org> Discussion: https://github.com/pgpool/pgpool2/issues/168 Backpatch-through: v4.3 add test Branch ------ V4_3_STABLE Details ------- https://git.postgresql.org/gitweb?p=pgpool2.git;a=commitdiff;h=27b933fe9dedfbe57f8d68f2043e9fbd9b4ef... Modified Files -------------- src/auth/pool_auth.c | 86 ++++++++++++++++++----- src/test/regression/tests/083.md5_warning/test.sh | 70 ++++++++++++++++++ 2 files changed, 137 insertions(+), 19 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgpool: Fix pool_do_auth. @ 2026-08-15 05:05 Tatsuo Ishii <ishii@postgresql.org> 0 siblings, 0 replies; 6+ messages in thread From: Tatsuo Ishii @ 2026-08-15 05:05 UTC (permalink / raw) To: pgpool-committers@lists.postgresql.org Fix pool_do_auth. From PostgreSQL 19, backend sends a notice message "authenticated with an MD5-encrypted password" if MD5 auth is used. Unfortunately it exercises an untested code path in pool_do_auth. It calls SimpleForwardToFrontend to forward the notice message to frontend. Unfortunately calling it in authentication phase is wrong, since "session contest" is not established yet. If the session context is not established, SimpleForwardToFrontend fails with FATAL. To fix this, create a new function "forward_message_to_frontend", which is basically a simple version of SimpleForwardToFrontend error, so that it does not raise the FATAL error. Also add 083.md5_warning test for this. Reported-by: harudini Author: Tatsuo Ishii <ishii@postgresql.org> Discussion: https://github.com/pgpool/pgpool2/issues/168 Backpatch-through: v4.3 add test Branch ------ V4_4_STABLE Details ------- https://git.postgresql.org/gitweb?p=pgpool2.git;a=commitdiff;h=2f1f80b52a193fb39c185f96f2d4e86bad009... Modified Files -------------- src/auth/pool_auth.c | 86 ++++++++++++++++++----- src/test/regression/tests/083.md5_warning/test.sh | 70 ++++++++++++++++++ 2 files changed, 137 insertions(+), 19 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgpool: Fix pool_do_auth. @ 2026-08-15 05:05 Tatsuo Ishii <ishii@postgresql.org> 0 siblings, 0 replies; 6+ messages in thread From: Tatsuo Ishii @ 2026-08-15 05:05 UTC (permalink / raw) To: pgpool-committers@lists.postgresql.org Fix pool_do_auth. From PostgreSQL 19, backend sends a notice message "authenticated with an MD5-encrypted password" if MD5 auth is used. Unfortunately it exercises an untested code path in pool_do_auth. It calls SimpleForwardToFrontend to forward the notice message to frontend. Unfortunately calling it in authentication phase is wrong, since "session contest" is not established yet. If the session context is not established, SimpleForwardToFrontend fails with FATAL. To fix this, create a new function "forward_message_to_frontend", which is basically a simple version of SimpleForwardToFrontend error, so that it does not raise the FATAL error. Also add 083.md5_warning test for this. Reported-by: harudini Author: Tatsuo Ishii <ishii@postgresql.org> Discussion: https://github.com/pgpool/pgpool2/issues/168 Backpatch-through: v4.3 add test Branch ------ V4_5_STABLE Details ------- https://git.postgresql.org/gitweb?p=pgpool2.git;a=commitdiff;h=b7f0da4e10b0bd3f833d4c7c077cb2252de53... Modified Files -------------- src/auth/pool_auth.c | 86 ++++++++++++++++++----- src/test/regression/tests/083.md5_warning/test.sh | 70 ++++++++++++++++++ 2 files changed, 137 insertions(+), 19 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgpool: Fix pool_do_auth. @ 2026-08-15 05:05 Tatsuo Ishii <ishii@postgresql.org> 0 siblings, 0 replies; 6+ messages in thread From: Tatsuo Ishii @ 2026-08-15 05:05 UTC (permalink / raw) To: pgpool-committers@lists.postgresql.org Fix pool_do_auth. From PostgreSQL 19, backend sends a notice message "authenticated with an MD5-encrypted password" if MD5 auth is used. Unfortunately it exercises an untested code path in pool_do_auth. It calls SimpleForwardToFrontend to forward the notice message to frontend. Unfortunately calling it in authentication phase is wrong, since "session contest" is not established yet. If the session context is not established, SimpleForwardToFrontend fails with FATAL. To fix this, create a new function "forward_message_to_frontend", which is basically a simple version of SimpleForwardToFrontend error, so that it does not raise the FATAL error. Also add 083.md5_warning test for this. Reported-by: harudini Author: Tatsuo Ishii <ishii@postgresql.org> Discussion: https://github.com/pgpool/pgpool2/issues/168 Backpatch-through: v4.3 add test Branch ------ V4_6_STABLE Details ------- https://git.postgresql.org/gitweb?p=pgpool2.git;a=commitdiff;h=9f99289bd097c66de43e9edd0a4b5185d5fcb... Modified Files -------------- src/auth/pool_auth.c | 86 ++++++++++++++++++----- src/test/regression/tests/083.md5_warning/test.sh | 70 ++++++++++++++++++ 2 files changed, 137 insertions(+), 19 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgpool: Fix pool_do_auth. @ 2026-08-15 05:05 Tatsuo Ishii <ishii@postgresql.org> 0 siblings, 0 replies; 6+ messages in thread From: Tatsuo Ishii @ 2026-08-15 05:05 UTC (permalink / raw) To: pgpool-committers@lists.postgresql.org Fix pool_do_auth. From PostgreSQL 19, backend sends a notice message "authenticated with an MD5-encrypted password" if MD5 auth is used. Unfortunately it exercises an untested code path in pool_do_auth. It calls SimpleForwardToFrontend to forward the notice message to frontend. Unfortunately calling it in authentication phase is wrong, since "session contest" is not established yet. If the session context is not established, SimpleForwardToFrontend fails with FATAL. To fix this, create a new function "forward_message_to_frontend", which is basically a simple version of SimpleForwardToFrontend error, so that it does not raise the FATAL error. Also add 133.md5_warning test for this. Reported-by: harudini Author: Tatsuo Ishii <ishii@postgresql.org> Discussion: https://github.com/pgpool/pgpool2/issues/168 Backpatch-through: v4.3 Test. Branch ------ V4_7_STABLE Details ------- https://git.postgresql.org/gitweb?p=pgpool2.git;a=commitdiff;h=08fbe906db7f751dca4a9aa9c44e688e653f3... Modified Files -------------- src/auth/pool_auth.c | 86 ++++++++++++++++++----- src/test/regression/tests/133.md5_warning/test.sh | 70 ++++++++++++++++++ 2 files changed, 137 insertions(+), 19 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgpool: Fix pool_do_auth. @ 2026-08-15 05:06 Tatsuo Ishii <ishii@postgresql.org> 0 siblings, 0 replies; 6+ messages in thread From: Tatsuo Ishii @ 2026-08-15 05:06 UTC (permalink / raw) To: pgpool-committers@lists.postgresql.org Fix pool_do_auth. From PostgreSQL 19, backend sends a notice message "authenticated with an MD5-encrypted password" if MD5 auth is used. Unfortunately it exercises an untested code path in pool_do_auth. It calls SimpleForwardToFrontend to forward the notice message to frontend. Unfortunately calling it in authentication phase is wrong, since "session contest" is not established yet. If the session context is not established, SimpleForwardToFrontend fails with FATAL. To fix this, create a new function "forward_message_to_frontend", which is basically a simple version of SimpleForwardToFrontend error, so that it does not raise the FATAL error. Also add 133.md5_warning test for this. Reported-by: harudini Author: Tatsuo Ishii <ishii@postgresql.org> Discussion: https://github.com/pgpool/pgpool2/issues/168 Backpatch-through: v4.3 Test. Branch ------ master Details ------- https://git.postgresql.org/gitweb?p=pgpool2.git;a=commitdiff;h=3c97bbdddaa11e0155f37ac335ce742b9276e... Modified Files -------------- src/auth/pool_auth.c | 86 ++++++++++++++++++----- src/test/regression/tests/133.md5_warning/test.sh | 70 ++++++++++++++++++ 2 files changed, 137 insertions(+), 19 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
end of thread, other threads:[~2026-08-15 05:06 UTC | newest] Thread overview: 6+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2026-08-15 05:05 pgpool: Fix pool_do_auth. Tatsuo Ishii <ishii@postgresql.org> 2026-08-15 05:05 pgpool: Fix pool_do_auth. Tatsuo Ishii <ishii@postgresql.org> 2026-08-15 05:05 pgpool: Fix pool_do_auth. Tatsuo Ishii <ishii@postgresql.org> 2026-08-15 05:05 pgpool: Fix pool_do_auth. Tatsuo Ishii <ishii@postgresql.org> 2026-08-15 05:05 pgpool: Fix pool_do_auth. Tatsuo Ishii <ishii@postgresql.org> 2026-08-15 05:06 pgpool: Fix pool_do_auth. Tatsuo Ishii <ishii@postgresql.org>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox