agora inbox for pgpool-committers@postgresql.org
help / color / mirror / Atom feedFrom: Tatsuo Ishii <ishii@postgresql.org>
To: pgpool-committers@lists.postgresql.org
Subject: pgpool: Fix pool_do_auth.
Date: Sat, 15 Aug 2026 05:05:50 +0000
Message-ID: <E1wv6ac-0000000APyn-23tU@gothos.postgresql.org> (raw)
Fix pool_do_auth.
From PostgreSQL 19, backend sends a notice message "authenticated with
an MD5-encrypted password" if MD5 auth is used. Unfortunately it
exercises an untested code path in pool_do_auth. It calls
SimpleForwardToFrontend to forward the notice message to
frontend. Unfortunately calling it in authentication phase is wrong,
since "session contest" is not established yet. If the session context
is not established, SimpleForwardToFrontend fails with FATAL.
To fix this, create a new function "forward_message_to_frontend",
which is basically a simple version of SimpleForwardToFrontend error,
so that it does not raise the FATAL error.
Also add 083.md5_warning test for this.
Reported-by: harudini
Author: Tatsuo Ishii <ishii@postgresql.org>
Discussion: https://github.com/pgpool/pgpool2/issues/168
Backpatch-through: v4.3
add test
Branch
------
V4_5_STABLE
Details
-------
https://git.postgresql.org/gitweb?p=pgpool2.git;a=commitdiff;h=b7f0da4e10b0bd3f833d4c7c077cb2252de53...
Modified Files
--------------
src/auth/pool_auth.c | 86 ++++++++++++++++++-----
src/test/regression/tests/083.md5_warning/test.sh | 70 ++++++++++++++++++
2 files changed, 137 insertions(+), 19 deletions(-)
view thread (6+ messages) latest in thread
Message-ID: <E1wv6ac-0000000APyn-23tU@gothos.postgresql.org>
Permalink: ../E1wv6ac-0000000APyn-23tU@gothos.postgresql.org/
Also on: postgresql.org/message-id/E1wv6ac-0000000APyn-23tU@gothos.postgresql.org
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgpool-committers@postgresql.org
Cc: ishii@postgresql.org, pgpool-committers@lists.postgresql.org
Subject: Re: pgpool: Fix pool_do_auth.
In-Reply-To: <E1wv6ac-0000000APyn-23tU@gothos.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox