agora inbox for pgpool-committers@postgresql.org  
help / color / mirror / Atom feed
From: Taiki Koshino <koshino@sraoss.co.jp>
To: pgpool-committers@lists.postgresql.org
Subject: pgpool: Fix response buffer pointer advancement in do_error_execute_com
Date: Fri, 18 Sep 2026 05:10:30 +0000
Message-ID: <E1x7Qrl-0000000CwVK-3rvL@gothos.postgresql.org> (raw)

Fix response buffer pointer advancement in do_error_execute_command

The response body is copied len bytes, but the buffer pointer was
advanced by sizeof(len). When a zero-length response body was received,
the pointer advanced by four bytes even though no body was copied,
causing subsequent saved responses to be corrupted.

Advance the pointer by len in both protocol v2 and v3 paths.

Author: Taiki Koshino <koshino@srasoss.co.jp>
Discussion: https://www.postgresql.org/message-id/OS9P286MB6486821B656397FBCD72BE5394BF2%40OS9P286MB6486.JPNP286...
Backpatch-through: v4.3

Branch
------
V4_4_STABLE

Details
-------
https://git.postgresql.org/gitweb?p=pgpool2.git;a=commitdiff;h=4b6b592e54b2d67b8944b66e9f4216732fe03...

Modified Files
--------------
src/protocol/pool_process_query.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)



view thread (6+ messages)  latest in thread

Message-ID: <E1x7Qrl-0000000CwVK-3rvL@gothos.postgresql.org>
Permalink:  ../E1x7Qrl-0000000CwVK-3rvL@gothos.postgresql.org/
Also on:    postgresql.org/message-id/E1x7Qrl-0000000CwVK-3rvL@gothos.postgresql.org

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgpool-committers@postgresql.org
  Cc: koshino@sraoss.co.jp, pgpool-committers@lists.postgresql.org
  Subject: Re: pgpool: Fix response buffer pointer advancement in do_error_execute_com
  In-Reply-To: <E1x7Qrl-0000000CwVK-3rvL@gothos.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox