pg.ddx.io  pgpool-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Taiki Koshino <koshino@sraoss.co.jp>
To: pgpool-committers@lists.postgresql.org
Subject: pgpool: Fix watchdog WD_INFO_MESSAGE processing to check wd_authkey.
Date: Tue, 29 Sep 2026 04:47:05 +0000
Message-ID: <E1xBPk9-00000002iw4-2r2Z@gothos.postgresql.org> (raw)

Fix watchdog WD_INFO_MESSAGE processing to check wd_authkey.

While processing WD_INFO_MESSAGE, standard_packet_processor() failed
to check wd_authkey before copying peer supplied fields (state,
startup_time, wd_priority, current_state_time, escalated,
standby_nodes_count, quorum_status, lifecheck_started, nodeName) into
the local WatchdogNode *before* validating the packet's authhash.  As
a result, an attacker was able to influence leader election with
invalid wd_authkey.

To fix this, call verify_authhash_for_node() before copying
peer-supplied state into the local WatchdogNode. If the verification
fails, emit a warning meesage and return.

Note that empty wd_authkey is still valid because
verify_authhash_for_node() returns success (true) if wd_authkey is an
empty string.

Reported-by: Emond Papegaaij <emond.papegaaij@topicus.nl>
Reported-by: Claude
Author: Tatsuo Ishii <ishii@postgresql.org>
CVE-2026-92873
Backpatch-through: v4.3

Branch
------
master

Details
-------
https://git.postgresql.org/gitweb?p=pgpool2.git;a=commitdiff;h=6117bb7f6ee97a76871607b657c9a26d3e924...

Modified Files
--------------
src/watchdog/watchdog.c | 17 +++++++++++++++++
1 file changed, 17 insertions(+)



view thread (6+ messages)

Message-ID: <E1xBPk9-00000002iw4-2r2Z@gothos.postgresql.org>
Permalink:  ../E1xBPk9-00000002iw4-2r2Z@gothos.postgresql.org/
Also on:    postgresql.org/message-id/E1xBPk9-00000002iw4-2r2Z@gothos.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgpool-committers@postgresql.org
  Cc: koshino@sraoss.co.jp
  Subject: Re: pgpool: Fix watchdog WD_INFO_MESSAGE processing to check wd_authkey.
  In-Reply-To: <E1xBPk9-00000002iw4-2r2Z@gothos.postgresql.org>
  References: <E1xBPk9-00000002iw4-2r2Z@gothos.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox