public inbox for [email protected]  

help / color / mirror / Atom feed

From: Tatsuo Ishii <[email protected]>
To: [email protected]
Cc: [email protected]
Subject: Re: Patch for fixing doc about some parameters.
Date: Wed, 02 Jul 2025 20:27:13 +0900 (JST)
Message-ID: <[email protected]> (raw)
In-Reply-To: <TYYP286MB2931EEDED823172BB0AE7D659440A@TYYP286MB2931.JPNP286.PROD.OUTLOOK.COM>
References: <TYYP286MB2931EEDED823172BB0AE7D659440A@TYYP286MB2931.JPNP286.PROD.OUTLOOK.COM>

> Fixed mistakes in the documentation for parameters.
> 
> "v1-0001-Fixed-documentation-for-parameters-that-are-not-r.patch"
> is a patch for ticket #10954
> "Test all the configuration parameters if reload is required."

There's one trainling whitespace.

$ git apply ~/v1-0001-Fixed-documentation-for-parameters-that-are-not-r.patch 
/home/t-ishii/v1-0001-Fixed-documentation-for-parameters-that-are-not-r.patch:39: trailing whitespace.
      このパラメータはサーバ起動時にのみ設定可能です。 
warning: 1 line adds whitespace errors.

> Subject: [PATCH v2] Fixed documentation for parameters that are not reflected
 by reload.

This comes from the commit title "Fixed documentation for parameters
that are not reflected by reload." We usually add "Doc:" prefix to the
commit header if the changes are only for documentations. Also "Fixed"
seems unnatural as a commit header. Instead use "fix". So something
like "Doc: fix documentation for parameters that are not reflected by
reload." is better,

> "v1-0001-Fix-documentation-for-enum-parameters-reported-as"
> is for ticket #8397

Please add "Doc:" prefix to the commit title as well.
#8397 is an internal number and you'd better to remove it.

Other than that, the patch looks good to me.

Best regards,
--
Tatsuo Ishii
SRA OSS K.K.
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: Patch for fixing doc about some parameters.
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox