public inbox for [email protected]help / color / mirror / Atom feed
pg_enc 4+ messages / 2 participants [nested] [flat]
* pg_enc @ 2025-09-23 06:49 刘进央 <[email protected]> 2025-09-23 07:09 ` Re: pg_enc Tatsuo Ishii <[email protected]> 0 siblings, 1 reply; 4+ messages in thread From: 刘进央 @ 2025-09-23 06:49 UTC (permalink / raw) To: [email protected] Hi， attatch is the patch for this issue, please help review it. issue link is https://github.com/pgpool/pgpool2/issues/129 I have verified it, the result as below: [root@test1 bin]# ./pg_enc -p -P db password: encryption key: PtFXv5keNmBzsARTtJduzw== pool_passwd string: AESPtFXv5keNmBzsARTtJduzw== Attachments: [application/octet-stream] pg_enc.patch (316B, 3-pg_enc.patch) download | inline diff: diff --git a/src/tools/pgenc/pg_enc.c b/src/tools/pgenc/pg_enc.c index d548fd6..de5740c 100644 --- a/src/tools/pgenc/pg_enc.c +++ b/src/tools/pgenc/pg_enc.c @@ -246,6 +246,7 @@ main(int argc, char *argv[]) exit(EXIT_FAILURE); } stpncpy(enc_key, buf, sizeof(enc_key)); + pool_key = enc_key; } else { ^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: pg_enc 2025-09-23 06:49 pg_enc 刘进央 <[email protected]> @ 2025-09-23 07:09 ` Tatsuo Ishii <[email protected]> 2025-09-24 00:55 ` Re: pg_enc Tatsuo Ishii <[email protected]> 0 siblings, 1 reply; 4+ messages in thread From: Tatsuo Ishii @ 2025-09-23 07:09 UTC (permalink / raw) To: [email protected]; +Cc: [email protected] > attatch is the patch for this issue, please help review it. Thanks. I will look into to the patch. In the mean time I discarded the pending message previously sent. > issue link is https://github.com/pgpool/pgpool2/issues/129 > > > > > I have verified it, the result as below: > > [root@test1 bin]# ./pg_enc -p -P > > db password: > > encryption key: Best regards, -- Tatsuo Ishii SRA OSS K.K. English: http://www.sraoss.co.jp/index_en/ Japanese:http://www.sraoss.co.jp ^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: pg_enc 2025-09-23 06:49 pg_enc 刘进央 <[email protected]> 2025-09-23 07:09 ` Re: pg_enc Tatsuo Ishii <[email protected]> @ 2025-09-24 00:55 ` Tatsuo Ishii <[email protected]> 2025-09-24 01:45 ` Re: pg_enc Tatsuo Ishii <[email protected]> 0 siblings, 1 reply; 4+ messages in thread From: Tatsuo Ishii @ 2025-09-24 00:55 UTC (permalink / raw) To: [email protected]; +Cc: [email protected] >> attatch is the patch for this issue, please help review it. > > Thanks. I will look into to the patch. In the mean time I discarded > the pending message previously sent. The patch looks good to me. I am going to push to all supported branches (down to 4.2). Also I will update the misleading comment (this is unrelated to the issue you pointed out, though). See attached patch. BTW, to credit you as the original author of the patch, I would like to ask you what you would like to be credited your name and email. Usually I pick up it from the email From: like this, Author: Tatsuo Ishii <[email protected]> But since you have your name in Chinese in the From: field, I cannot include it in the commit message. Can you provide your name in ASCII letters? Or you can omit it and the Author field would become: Author: [email protected] It's up to your choice. Best regards, -- Tatsuo Ishii SRA OSS K.K. English: http://www.sraoss.co.jp/index_en/ Japanese:http://www.sraoss.co.jp Attachments: [application/octet-stream] v2_pg_enc.patch (914B, 2-v2_pg_enc.patch) download | inline diff: diff --git a/src/tools/pgenc/pg_enc.c b/src/tools/pgenc/pg_enc.c index 83c6d3b4f..7e5143843 100644 --- a/src/tools/pgenc/pg_enc.c +++ b/src/tools/pgenc/pg_enc.c @@ -5,7 +5,7 @@ * pgpool: a language independent connection pool server for PostgreSQL * written by Tatsuo Ishii * - * Copyright (c) 2003-2022 PgPool Global Development Group + * Copyright (c) 2003-2025 PgPool Global Development Group * * Permission to use, copy, modify, and distribute this software and * its documentation for any purpose and without fee is hereby @@ -98,7 +98,7 @@ main(int argc, char *argv[]) { switch (opt) { - case 'p': /* prompt for postgres password */ + case 'p': /* prompt for password to be encrypted */ prompt = true; break; @@ -246,6 +246,7 @@ main(int argc, char *argv[]) exit(EXIT_FAILURE); } stpncpy(enc_key, buf, sizeof(enc_key)); + pool_key = enc_key; } else { ^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: pg_enc 2025-09-23 06:49 pg_enc 刘进央 <[email protected]> 2025-09-23 07:09 ` Re: pg_enc Tatsuo Ishii <[email protected]> 2025-09-24 00:55 ` Re: pg_enc Tatsuo Ishii <[email protected]> @ 2025-09-24 01:45 ` Tatsuo Ishii <[email protected]> 0 siblings, 0 replies; 4+ messages in thread From: Tatsuo Ishii @ 2025-09-24 01:45 UTC (permalink / raw) To: [email protected]; +Cc: [email protected] Fix pushed to all supported branches. Thank you! -- Tatsuo Ishii SRA OSS K.K. English: http://www.sraoss.co.jp/index_en/ Japanese:http://www.sraoss.co.jp From: 刘进央 <[email protected]> Subject: Re: Re: pg_enc Date: Wed, 24 Sep 2025 09:02:57 +0800 (GMT+08:00) Message-ID: <[email protected]> > hi ishii: > > name : jinyang liu > email: [email protected] > > thanks > > >> -----原始邮件----- >> 发件人: "Tatsuo Ishii" <[email protected]> >> 发送时间:2025-09-24 08:55:27 (星期三) >> 收件人: [email protected] >> 抄送: [email protected] >> 主题: Re: pg_enc >> >> >> attatch is the patch for this issue, please help review it. >> > >> > Thanks. I will look into to the patch. In the mean time I discarded >> > the pending message previously sent. >> >> The patch looks good to me. I am going to push to all supported >> branches (down to 4.2). Also I will update the misleading comment >> (this is unrelated to the issue you pointed out, though). See attached >> patch. >> >> BTW, to credit you as the original author of the patch, I would like >> to ask you what you would like to be credited your name and >> email. Usually I pick up it from the email From: like this, >> >> Author: Tatsuo Ishii <[email protected]> >> >> But since you have your name in Chinese in the From: field, I cannot >> include it in the commit message. Can you provide your name in ASCII >> letters? Or you can omit it and the Author field would become: >> >> Author: [email protected] >> >> It's up to your choice. >> >> Best regards, >> -- >> Tatsuo Ishii >> SRA OSS K.K. >> English: http://www.sraoss.co.jp/index_en/ >> Japanese:http://www.sraoss.co.jp ^ permalink raw reply [nested|flat] 4+ messages in thread
end of thread, other threads:[~2025-09-24 01:45 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2025-09-23 06:49 pg_enc 刘进央 <[email protected]> 2025-09-23 07:09 ` Tatsuo Ishii <[email protected]> 2025-09-24 00:55 ` Tatsuo Ishii <[email protected]> 2025-09-24 01:45 ` Tatsuo Ishii <[email protected]>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox