public inbox for [email protected]
help / color / mirror / Atom feedFrom: Emond Papegaaij <[email protected]>
To: Tatsuo Ishii <[email protected]>
Cc: [email protected]
Subject: Re: [PATCH] Segfault in pool_do_auth() when failover races with a new connection
Date: Thu, 2 Jul 2026 15:54:56 +0200
Message-ID: <CAGXsc+YzD3khY8QAF+LFgX4SQ9U2wei9-JumeMzD1M0=WxrbFA@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <CAGXsc+Y7OKp93zSqt1WUCh7ABC7kyZqrxJPFA8AC1woB30S8EQ@mail.gmail.com>
<[email protected]>
<CAGXsc+aizSg6Z22=pV8NsFb-FukzT2XP1YriOkOJjOBLVdN-vg@mail.gmail.com>
<[email protected]>
Hi Tatsuo,
Yes, this looks good. There's one small nit: there's some whitespace
noise in the patch (space before tab) on the line with
"my_main_node_id = *(volatile int *) &REAL_MAIN_NODE_ID;"
Best regards,
Emond
Op do 2 jul 2026 om 15:45 schreef Tatsuo Ishii <[email protected]>:
>
> Hi Emond,
>
> > The new patch looks fine to me. There's however one thing Claude
> > pointed out. According to it, my_main_node_id,
> > private_backend_status[], and my_backend_status[] are per-process
> > globals (copied on fork), not shared memory. So, making any of those
> > volatile should not make any difference.
>
> You are right. Attached is the v3 patch.
>
> Regards,
> --
> Tatsuo Ishii
> SRA OSS K.K.
> English: http://www.sraoss.co.jp/index_en/
> Japanese:http://www.sraoss.co.jp
view thread (8+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected]
Subject: Re: [PATCH] Segfault in pool_do_auth() when failover races with a new connection
In-Reply-To: <CAGXsc+YzD3khY8QAF+LFgX4SQ9U2wei9-JumeMzD1M0=WxrbFA@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox