From: Simon Riggs <simon@2ndquadrant.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Jeff Frost <jeff@frostconsultingllc.com>
Cc: pgsql-hackers@postgreSQL.org
Subject: Re: [ADMIN] does wal archiving block the current client
Date: Tue, 23 May 2006 16:17:12 +0100
Message-ID: <1148397432.2646.837.camel@localhost.localdomain> (raw)
In-Reply-To: <5781.1148396964@sss.pgh.pa.us>
References: <Pine.LNX.4.64.0605150914360.9581@discord.dyndns.org>
<Pine.LNX.4.64.0605151554000.9581@discord.dyndns.org>
<727.1148054597@sss.pgh.pa.us>
<1148056053.2646.672.camel@localhost.localdomain>
<1148395755.2646.825.camel@localhost.localdomain>
<3835.1148396027@sss.pgh.pa.us>
<1148396461.2646.833.camel@localhost.localdomain>
<5781.1148396964@sss.pgh.pa.us>
On Tue, 2006-05-23 at 11:09 -0400, Tom Lane wrote:
> Simon Riggs <simon@2ndquadrant.com> writes:
> > On Tue, 2006-05-23 at 10:53 -0400, Tom Lane wrote:
> >> I think we just need a PostmasterIsAlive check in the per-file loop.
>
> > ...which would mean the archiver would not outlive postmaster in the
> > event it crashes...which is exactly the time you want it to keep going.
>
> Postmaster crashes are not a problem in practice; we've been careful to
> keep the postmaster doing so little that there's no material risk of it
> failing. If the postmaster dies it's almost certainly because someone
> killed it, and you really want the child processes to close up shop too.
>
> (If we did want the archiver to keep running, it shouldn't have any
> PostmasterIsAlive check at all; I can't see a reason why completing
> one iteration of the outer loop is a better time to stop than any
> other time.)
This does at least solve the fast restart problem, so look on -patches
in a few minutes.
--
Simon Riggs
EnterpriseDB http://www.enterprisedb.com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-admin@postgresql.org
Cc: simon@2ndquadrant.com, tgl@sss.pgh.pa.us, jeff@frostconsultingllc.com, pgsql-hackers@postgreSQL.org
Subject: Re: [ADMIN] does wal archiving block the current client
In-Reply-To: <1148397432.2646.837.camel@localhost.localdomain>
References: <Pine.LNX.4.64.0605150914360.9581@discord.dyndns.org> <Pine.LNX.4.64.0605151554000.9581@discord.dyndns.org> <727.1148054597@sss.pgh.pa.us> <1148056053.2646.672.camel@localhost.localdomain> <1148395755.2646.825.camel@localhost.localdomain> <3835.1148396027@sss.pgh.pa.us> <1148396461.2646.833.camel@localhost.localdomain> <5781.1148396964@sss.pgh.pa.us> <1148397432.2646.837.camel@localhost.localdomain>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox