pg.ddx.io  pgsql-admin@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Simon Riggs <simon@2ndQuadrant.com>
Cc: Rural Hunter <ruralhunter@gmail.com>
Cc: pgsql-admin@postgresql.org
Subject: Re: replication failure with GIN index
Date: Fri, 06 Apr 2012 10:01:09 -0400
Message-ID: <12895.1333720869@sss.pgh.pa.us> (raw)
In-Reply-To: <CA+U5nM+Tw7dMH7gvL6mVpZ0JbtWBhCf+tkmES25XjN8ZU4+ESA@mail.gmail.com>
References: <4F7E4D49.1040106@gmail.com>
	<CA+U5nM+Tw7dMH7gvL6mVpZ0JbtWBhCf+tkmES25XjN8ZU4+ESA@mail.gmail.com>

Simon Riggs <simon@2ndQuadrant.com> writes:
> On Fri, Apr 6, 2012 at 2:56 AM, Rural Hunter <ruralhunter@gmail.com> wrote:
>> 2012-04-06 02:37:27 CST [@] PANIC:  GIN metapage disappeared

Known bug, see
http://git.postgresql.org/gitweb/?p=postgresql.git;a=commitdiff;h=57b100fe0fb1d0d5803789d3113b89fa18...

>> 2012-04-06 02:37:27 CST [@] CONTEXT:  xlog redo Update metapage, node:
>> 37547844/16405/83896882 blkno: 4294967295

> The blkno is all wrong, so it looks like a clear bug to me.

[ looks into that... ]  The funny blkno is attributable to this
overly-cute code:

		case XLOG_GIN_UPDATE_META_PAGE:
			appendStringInfo(buf, "Update metapage, ");
			desc_node(buf, ((ginxlogUpdateMeta *) rec)->node, ((ginxlogUpdateMeta *) rec)->metadata.tail);
			break;

and we also have

		case XLOG_GIN_DELETE_LISTPAGE:
			appendStringInfo(buf, "Delete list pages (%d), ", ((ginxlogDeleteListPages *) rec)->ndeleted);
			desc_node(buf, ((ginxlogDeleteListPages *) rec)->node, ((ginxlogDeleteListPages *) rec)->metadata.head);
			break;

While there could be some point in printing the list head or tail
pointer, it's just confusing to print it with a label of "blkno".
I think we should just print the metapage block number here and
be done with it.

			regards, tom lane



view thread (3+ messages)

Message-ID: <12895.1333720869@sss.pgh.pa.us>
Permalink:  ../12895.1333720869@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/12895.1333720869@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-admin@postgresql.org
  Cc: tgl@sss.pgh.pa.us, simon@2ndQuadrant.com, ruralhunter@gmail.com
  Subject: Re: replication failure with GIN index
  In-Reply-To: <12895.1333720869@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox