pg.ddx.io  pgsql-admin@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Jeff Frost <jeff@frostconsultingllc.com>
Cc: pgsql-admin@postgresql.org
Subject: Re: pg_dumpall 8.1.4 large objects error
Date: Fri, 09 Jun 2006 12:43:02 -0400
Message-ID: <12965.1149871382@sss.pgh.pa.us> (raw)
In-Reply-To: <Pine.LNX.4.64.0606090918550.27250@glacier.frostconsultingllc.com>
References: <Pine.LNX.4.64.0606061826420.23923@discord.home.frostconsultingllc.com>
	<25292.1149650216@sss.pgh.pa.us>
	<Pine.LNX.4.64.0606070950040.27250@glacier.frostconsultingllc.com>
	<Pine.LNX.4.64.0606090918550.27250@glacier.frostconsultingllc.com>

Jeff Frost <jeff@frostconsultingllc.com> writes:
>> On Tue, 6 Jun 2006, Tom Lane wrote:
>>> I'd try a REINDEX of pg_largeobject to see if that fixes it.

> Got the REINDEX completed and found a new error that I haven't seen before:

> pg_dump: SQL command failed
> pg_dump: Error message from server: ERROR:  Memory exhausted in AllocSetAlloc(96)

Hm, I'm not sure why it did that.  Possibly an ANALYZE on pg_largeobject
would change the plan for the SELECT DISTINCT and get you out of
trouble.

> Would it be better and more efficient to just pg_dumpall the globals and 
> pg_dump in custom format the vsl_cs db?

Won't help AFAIK --- that query will be used for blob dumping in all
cases.  Or actually, according to the cursor name, this is the query
for dumping blob comments.

> Server is 7.3.2, and the plan is to upgrade it.

Might be worth your while to update the server to 7.3.latest in-place.
The list of bugs fixed in 7.3.x is very long; I'm too lazy to look and
see if any of them look related to this, but it's possible.

Also, if you don't mind altering pg_dump, it looks to me like the query
being used here is unnecessarily inefficient:

    /* Cursor to get all BLOB comments */
    if (AH->remoteVersion >= 70200)
        blobQry = "DECLARE blobcmt CURSOR FOR SELECT DISTINCT loid, obj_description(loid, 'pg_largeobject') FROM pg_largeobject";

This is computing obj_description() redundantly for each pg_largeobject
chunk.  Perhaps there is a memory leak in obj_description() in 7.3.2?
If so it'd help to use

DECLARE blobcmt CURSOR FOR
  SELECT loid, obj_description(loid,'pg_largeobject')
  FROM (SELECT DISTINCT loid FROM pg_largeobject) ss;

(Think I'll go change this in CVS, too, as it's obviously tremendously
inefficient if you've got big large objects...)

			regards, tom lane



view thread (11+ messages)  latest in thread

Message-ID: <12965.1149871382@sss.pgh.pa.us>
Permalink:  ../12965.1149871382@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/12965.1149871382@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-admin@postgresql.org
  Cc: tgl@sss.pgh.pa.us, jeff@frostconsultingllc.com
  Subject: Re: pg_dumpall 8.1.4 large objects error
  In-Reply-To: <12965.1149871382@sss.pgh.pa.us>
  References: <Pine.LNX.4.64.0606061826420.23923@discord.home.frostconsultingllc.com> <25292.1149650216@sss.pgh.pa.us> <Pine.LNX.4.64.0606070950040.27250@glacier.frostconsultingllc.com> <Pine.LNX.4.64.0606090918550.27250@glacier.frostconsultingllc.com> <12965.1149871382@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox