From: Alvaro Herrera <alvherre@commandprompt.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Tatsuo Ishii <ishii@postgresql.org>
Cc: mangoo <mangoo@wpkg.org>
Cc: scott.marlowe <scott.marlowe@gmail.com>
Cc: Kevin.Grittner <kevin.grittner@wicourts.gov>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: pgpool versus sequences
Date: Thu, 02 Jun 2011 10:55:26 -0400
Message-ID: <1307026309-sup-4021@alvh.no-ip.org> (raw)
In-Reply-To: <14930.1307025118@sss.pgh.pa.us>
References: <26909.1306965898@sss.pgh.pa.us>
<BANLkTikCRTeZ_g-rDay4RukWOY3Q7irCnQ@mail.gmail.com>
<27741.1306968830@sss.pgh.pa.us>
<20110602.080816.460114267356667394.t-ishii@sraoss.co.jp>
<1306971997-sup-5549@alvh.no-ip.org>
<BANLkTimgVA7mi2SP_ZVH-fsUB3VShTsMng@mail.gmail.com>
<14930.1307025118@sss.pgh.pa.us>
Excerpts from Tom Lane's message of jue jun 02 10:31:58 -0400 2011:
> Robert Haas <robertmhaas@gmail.com> writes:
> > On Wed, Jun 1, 2011 at 7:47 PM, Alvaro Herrera
> > <alvherre@commandprompt.com> wrote:
> >> Yeah -- why is LOCK SEQUENCE foo_seq not allowed? Seems a simple thing
> >> to have.
>
> > It cause a grammar conflict.
>
> That's a lot of work for a purely cosmetic issue, though. What would be
> trivial is to let this work:
>
> regression=# create sequence s1;
> CREATE SEQUENCE
> regression=# begin;
> BEGIN
> regression=# lock table s1;
> ERROR: "s1" is not a table
Yeah, though it'd be nice to avoid this:
alvherre=# create schema public_too;
CREATE SCHEMA
alvherre=# set search_path to 'public_too', 'public';
SET
alvherre=# create table public_too.s1 ();
CREATE TABLE
alvherre=# create sequence public.s1;
CREATE SEQUENCE
alvherre=# begin;
BEGIN
alvherre=# lock s1;
LOCK TABLE
At this point we have a lock on the table, but if we change LOCK to also
look for sequences, the behavior would change. At the very least, the
command tag should be different.
Hopefully few people name sequences the same as tables ...
--
Álvaro Herrera <alvherre@commandprompt.com>
The PostgreSQL Company - Command Prompt, Inc.
PostgreSQL Replication, Consulting, Custom Development, 24x7 support
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-admin@postgresql.org
Cc: alvherre@commandprompt.com, tgl@sss.pgh.pa.us, robertmhaas@gmail.com, ishii@postgresql.org, mangoo@wpkg.org, scott.marlowe@gmail.com, kevin.grittner@wicourts.gov, pgsql-hackers@postgresql.org
Subject: Re: pgpool versus sequences
In-Reply-To: <1307026309-sup-4021@alvh.no-ip.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox