From: Guillaume Lelarge <guillaume@lelarge.info>
To: Scott Ribe <scott_ribe@elevated-dev.com>
Cc: Brian Weaver <cmdrclueless@gmail.com>
Cc: pgsql-admin@postgresql.org <pgsql-admin@postgresql.org>
Subject: Re: Problems with pg_restore (plpgsql already exists)
Date: Sat, 25 Feb 2012 19:10:09 +0100
Message-ID: <1330193409.2593.5.camel@localhost.localdomain> (raw)
In-Reply-To: <274BAD81-38BF-4537-B474-ADCDF77E318A@elevated-dev.com>
References: <EB254343-461B-4B6B-93A1-3065BA902CF3@gmail.com>
<4F4820C8.2000703@iii.com>
<CAAhXZGv+sU3SksPi-hn2GECf2O_-Xt-xBANgCJyuWDwFiUDnAQ@mail.gmail.com>
<1330183903.2593.1.camel@localhost.localdomain>
<17919563-C079-438C-9702-5A0806127DFD@gmail.com>
<274BAD81-38BF-4537-B474-ADCDF77E318A@elevated-dev.com>
On Sat, 2012-02-25 at 09:23 -0700, Scott Ribe wrote:
> On Feb 25, 2012, at 9:18 AM, Brian Weaver wrote:
>
> > Thanks for the pointer. Is it just me that finds it the behavior of pg_restore odd? If the default installation since 9.0 has PL/PgSQL installed then why does pg_restore still emit statements to create the language? As a developer by trade it smells like a bug.
>
> It's pg_dump that's emitting the command to create the language. If you ran pg_dump from 9.0+, it would not do so.
Not quite true. pg_dump from 9.0 does save the language definition, but
it uses the new CREATE OR REPLACE statement for languages, so that, when
you restore it in a 9.0+ database that already has the same language, it
won't complain with an error message.
BTW, it isn't odd that pg_dump 9.0 save the language definition. Having
by default the plpgsql language when you create a database doesn't mean
you can't drop it.
> This is an example of why the standard advice for upgrading is to use the newer pg_dump against the older database
Exactly.
--
Guillaume
http://blog.guillaume.lelarge.infohttp://www.dalibo.com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-admin@postgresql.org
Cc: guillaume@lelarge.info, scott_ribe@elevated-dev.com, cmdrclueless@gmail.com
Subject: Re: Problems with pg_restore (plpgsql already exists)
In-Reply-To: <1330193409.2593.5.camel@localhost.localdomain>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox