pg.ddx.io  pgsql-admin@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: meetesh.karia@alumni.duke.edu
Cc: Robert Treat <xzilla@users.sourceforge.net>
Cc: pgsql-admin@postgresql.org
Cc: pgsql-hackers@postgresql.org
Subject: Re: Encoding problems with migration from 8.0.14 to 8.3.0 on Windows
Date: Thu, 13 Mar 2008 11:43:22 -0400
Message-ID: <17759.1205423002@sss.pgh.pa.us> (raw)
In-Reply-To: <47D8FB49.6000406@gmail.com>
References: <47D7CBAA.4090308@gmail.com>
	<47D7DC8C.7000204@gmail.com>
	<200803122328.42683.xzilla@users.sourceforge.net>
	<47D8FB49.6000406@gmail.com>

Meetesh Karia <meetesh.karia@gmail.com> writes:
> Additionally, here's what I get when I run your test below (my server 
> encoding is UTF-8):

> ltefull=# create table x (r varchar(255) unique);
> NOTICE:  CREATE TABLE / UNIQUE will create implicit index "x_r_key" for 
> table "x"
> CREATE TABLE
> ltefull=#
> ltefull=# set client_encoding=WIN1250;
> SET
> ltefull=# insert into x (r) values ('Daniel Brühl');
> INSERT 0 1
> ltefull=#
> ltefull=# insert into x (r) values ('Daniel Bruehl');
> ERROR:  duplicate key value violates unique constraint "x_r_key"

You said this was on Windows, right?

I was about to say "that should be impossible", until I looked at
varstr_cmp() and realized that whoever put in the WIN32/UTF8
special case omitted this part:

        /*
         * In some locales strcoll() can claim that nonidentical strings are
         * equal.  Believing that would be bad news for a number of reasons,
         * so we follow Perl's lead and sort "equal" strings according to
         * strcmp().
         */
        if (result == 0)
            result = strcmp(a1p, a2p);

So we behave differently on Windows (with UTF8) than anywhere else.
This is pretty nasty, not least because it means that texteq is
inconsistent with other text comparison operators.

I think this is a "must fix" bug for 8.3.1, anyone disagree?

			regards, tom lane



view thread (8+ messages)  latest in thread

Message-ID: <17759.1205423002@sss.pgh.pa.us>
Permalink:  ../17759.1205423002@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/17759.1205423002@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-admin@postgresql.org
  Cc: tgl@sss.pgh.pa.us, meetesh.karia@alumni.duke.edu, xzilla@users.sourceforge.net, pgsql-hackers@postgresql.org
  Subject: Re: Encoding problems with migration from 8.0.14 to 8.3.0 on Windows
  In-Reply-To: <17759.1205423002@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox