pg.ddx.io  pgsql-admin@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Bruce Momjian <pgman@candle.pha.pa.us>
To: Tsirkin Evgeny <tsurkin@mail.jct.ac.il>
Cc: Naomi Walker <nwalker@eldocomp.com>
Cc: Mark M. Huber <MHuber@VMdirect.com>
Cc: pgsql-admin@postgresql.org <pgsql-admin@postgresql.org>
Subject: Re: [Retrieved]RE: backup and recovery
Date: Wed, 24 Mar 2004 13:15:19 -0500 (EST)
Message-ID: <200403241815.i2OIFJS02678@candle.pha.pa.us> (raw)
In-Reply-To: <opr5dn0x0kjbdarf@localhost>

Tsirkin Evgeny wrote:
> > Uh, you just ask and we discuss it on the list.
> >
> > Are you using INSERTs from pg_dump?  I assume so because COPY uses a
> > single transaction per command.  Right now with pg_dump -d I see:
> > 	
> > 	--
> > 	-- Data for Name: has_oids; Type: TABLE DATA; Schema: public; Owner:
> > 	postgres
> > 	--
> > 	
> > 	INSERT INTO has_oids VALUES (1);
> > 	INSERT INTO has_oids VALUES (1);
> > 	INSERT INTO has_oids VALUES (1);
> > 	INSERT INTO has_oids VALUES (1);
> >
> > Seems that should be inside a BEGIN/COMMIT for performance reasons, and
> > to have the same behavior as COPY (fail if any row fails).  Commands?
> >
> > As far as skipping on errors, I am unsure on that one, and if we put the
> > INSERTs in a transaction, we will have no way of rolling back only the
> > few inserts that fail.
> >
> That is right but there are sutuation when you prefer at least some
> data to be inserted and not all changes to be ralled back because
> of errors.

Added to TODO:

	* Have pg_dump use multi-statement transactions for INSERT dumps

For simple performance reasons, it would be good.  I am not sure about
allowing errors to continue loading.   Anyone else?

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073



view thread (21+ messages)  latest in thread

Message-ID: <200403241815.i2OIFJS02678@candle.pha.pa.us>
Permalink:  ../200403241815.i2OIFJS02678@candle.pha.pa.us/
Also on:    postgresql.org/message-id/200403241815.i2OIFJS02678@candle.pha.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-admin@postgresql.org
  Cc: pgman@candle.pha.pa.us, tsurkin@mail.jct.ac.il, nwalker@eldocomp.com, MHuber@VMdirect.com
  Subject: Re: [Retrieved]RE: backup and recovery
  In-Reply-To: <200403241815.i2OIFJS02678@candle.pha.pa.us>
  References: <opr5dn0x0kjbdarf@localhost> <200403241815.i2OIFJS02678@candle.pha.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox