pg.ddx.io  pgsql-admin@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Alvaro Herrera <alvherre@commandprompt.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: dx k9 <bitsandbytes88@hotmail.com>
Cc: pgsql-admin@postgresql.org
Cc: pgsql-hackers@postgresql.org
Subject: Re: reindexdb hangs
Date: Thu, 30 Aug 2007 12:41:51 -0400
Message-ID: <20070830164151.GS5872@alvh.no-ip.org> (raw)
In-Reply-To: <12577.1188428726@sss.pgh.pa.us>
References: <BAY116-F2261C1BEF758D30196729DD1420@phx.gbl>
	<22018.1178144703@sss.pgh.pa.us>
	<20070825222150.GU31461@alvh.no-ip.org>
	<4909.1188082313@sss.pgh.pa.us>
	<20070829222341.GX7911@alvh.no-ip.org>
	<12577.1188428726@sss.pgh.pa.us>

Tom Lane wrote:
> Alvaro Herrera <alvherre@commandprompt.com> writes:
> > Tom Lane wrote:
> >> Yeah, an extra fetch of the pg_class row doesn't seem all that nice.
> >> I think you'd want to check it in approximately the same two places
> >> where pg_class_ownercheck() is applied (one for the 1-xact and one for
> >> the multi-xact path).
> 
> > Actually, the 1-xact path does not need it, because the check is already
> > elsewhere.
> 
> Yeah, but if you do it there it's one added comparison
> (isOtherTempNamespace is very cheap, and you can get the namespace
> cheaply from the already-open rel).  This way you need an extra syscache
> lookup because you are insisting on doing the check in a place where you
> don't have easy access to the pg_class row.  Doesn't seem better.

I'm not sure I follow.  Are you suggesting adding a new function,
similar to pg_class_ownercheck, which additionally checks for temp-ness?

-- 
Alvaro Herrera                                http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.



view thread (14+ messages)  latest in thread

Message-ID: <20070830164151.GS5872@alvh.no-ip.org>
Permalink:  ../20070830164151.GS5872@alvh.no-ip.org/
Also on:    postgresql.org/message-id/20070830164151.GS5872@alvh.no-ip.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-admin@postgresql.org
  Cc: alvherre@commandprompt.com, tgl@sss.pgh.pa.us, bitsandbytes88@hotmail.com, pgsql-hackers@postgresql.org
  Subject: Re: reindexdb hangs
  In-Reply-To: <20070830164151.GS5872@alvh.no-ip.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox